PHP 7 & above breaking changes

[absalomedia]

The use of $this as a reassignable variable is no longer permitted under PHP 7.0 & explicitly is forbidden in PHP 7.1. This is exposed when you upgrade CodeIgniter to latest edition inside GoCart.

This affects line 24 & 47 of application/core/AdminController.php where it specifies:
$vars['this'] = $this;

What do you think is an acceptable solution?

[olimortimer]

Do you have a link to the docs explaining that '$this as a reassignable variable is no longer permitted' please, as I can't seem to locate it?

I've tried my GoCart under PHP 7.0 and 7.1, and don't see the error with $this.

Do you have any steps to replicate it please? You mention upgrading CodeIgniter within GoCart?

[absalomedia]

1. Download your build at master
2. Patch to CodeIgniter 3.1.3 by replacing /system & /application folders
3. Patch base_url upgrade with config.php fixes from PR I've already done here - line 20 - domain rendering of CSS/JS/img assets will be broken otherwise
4. Set up test database using HeidiSQL or Sequel Pro or equivalent.
5. Run install sequence for GoCart. All things being equal it should install fine.
6. Frontend will be massively broken (related to $this variable) & upon browsing to admin login sequence & attempting to login, it will throw reassign $this error on PHP 7.1

I'm running Ubuntu 14.05 with PHP 7.1 inside Vagrant (replicated on both OSX & Windows Vagrant instances)

[olimortimer]

Thank you for the steps. I would be tempted to say that the two $vars['this'] = $this; lines can be removed from AdminController.php, as it doesn't look like they are used in any views. However I would like to ask @gocart to confirm that he is happy for these lines to be removed.

Once confirmed, would you like to issue a pull request for the 3.0.0 -> 3.1.3 upgrade?

[absalomedia]

@olimortimer commenting them out of the AdminController file doesn't break anything, but there's some kind of cascading effect where the frontend login sequence no longer works either, upon upgrade to 3.1.3. I can still log into the /admin area fine.

So there's a critical bug in the way GoCart works with CodeIgniter 3.1.3. Can you please verify it?

[absalomedia]

Further investigation:

• Patching to 3.0.6 works for frontend login
• 3.1.0 & above does not

[rupalgohel]

any work around here