Move plugin settings to separate plugin_settings table

Plugin settings were stored in the main settings table with namespaced
keys (analytics.enabled, analytics.tracking_id), which caused them to
appear in the global settings form.

- Add PluginSetting model with composite PK (plugin_name, key)
- Auto-migrate plugin_settings table in Registry.Init()
- Add UpdateSetting method on Registry
- Add PATCH /api/v1/plugin-settings endpoint for saving plugin settings
- Update JS to use the new endpoint for both toggle and form save
- Remove blog.Setting dependency from plugin package

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: compscidr

admin/admin.go

@@ -67,6 +67,45 @@ func (a *Admin) getPluginSettings(c *gin.Context) interface{} {
 	return nil
 }
 
+// UpdatePluginSettings saves plugin settings via the plugin registry.
+func (a *Admin) UpdatePluginSettings(c *gin.Context) {
+	if !a.auth.IsAdmin(c) {
+		c.JSON(http.StatusUnauthorized, "Not Authorized")
+		return
+	}
+
+	var settings []struct {
+		Key   string `json:"key"`
+		Value string `json:"value"`
+	}
+	if err := c.BindJSON(&settings); err != nil {
+		c.JSON(http.StatusBadRequest, "Malformed request")
+		return
+	}
+
+	reg, exists := c.Get("plugin_registry")
+	if !exists {
+		c.JSON(http.StatusInternalServerError, "Plugin registry not available")
+		return
+	}
+	r, ok := reg.(*gplugin.Registry)
+	if !ok {
+		c.JSON(http.StatusInternalServerError, "Plugin registry not available")
+		return
+	}
+
+	for _, s := range settings {
+		// Key format is "pluginname.settingkey"
+		parts := strings.SplitN(s.Key, ".", 2)
+		if len(parts) != 2 {
+			continue
+		}
+		r.UpdateSetting(parts[0], parts[1], s.Value)
+	}
+
+	c.JSON(http.StatusAccepted, settings)
+}
+
 func (a *Admin) UpdateDb(db *gorm.DB) {
 	a.db = &db
 }

goblog.go

@@ -387,6 +387,7 @@ func main() {
 	router.POST("/test_db", testDB)
 	router.POST("/api/v1/upload", goblog._admin.UploadFile)
 	router.PATCH("/api/v1/settings", goblog._admin.UpdateSettings)
+	router.PATCH("/api/v1/plugin-settings", goblog._admin.UpdatePluginSettings)
 	//if we use true here - it will override the home route and just show files
 	router.Use(static.Serve("/", static.LocalFile("www", false)))
 	if err != nil {

plugin/registry.go

@@ -1,7 +1,6 @@
 package plugin
 
 import (
-	"goblog/blog"
 	"log"
 	"sync"
 	"time"
@@ -64,15 +63,16 @@ func (r *Registry) Init() error {
 	if r.db == nil {
 		return nil
 	}
+	// Create the plugin_settings table if it doesn't exist
+	r.db.AutoMigrate(&PluginSetting{})
 	for _, p := range r.plugins {
 		for _, s := range p.Settings() {
-			fullKey := p.Name() + "." + s.Key
-			setting := blog.Setting{
-				Key:   fullKey,
-				Type:  s.Type,
-				Value: s.DefaultValue,
+			setting := PluginSetting{
+				PluginName: p.Name(),
+				Key:        s.Key,
+				Value:      s.DefaultValue,
 			}
-			r.db.Where("key = ?", fullKey).FirstOrCreate(&setting)
+			r.db.Where("plugin_name = ? AND key = ?", p.Name(), s.Key).FirstOrCreate(&setting)
 		}
 		if err := p.OnInit(r.db); err != nil {
 			log.Printf("Plugin %s init error: %v", p.Name(), err)
@@ -112,15 +112,13 @@ func (r *Registry) Stop() {
 	close(r.stopCh)
 }
 
-// getPluginSettings returns a plugin's settings as a map with the
-// namespace prefix stripped (e.g. "analytics.tracking_id" -> "tracking_id").
+// getPluginSettings returns a plugin's settings as a simple key→value map.
 func (r *Registry) getPluginSettings(pluginName string) map[string]string {
-	var settings []blog.Setting
-	prefix := pluginName + "."
-	r.db.Where("key LIKE ?", prefix+"%").Find(&settings)
+	var settings []PluginSetting
+	r.db.Where("plugin_name = ?", pluginName).Find(&settings)
 	result := make(map[string]string)
 	for _, s := range settings {
-		result[s.Key[len(prefix):]] = s.Value
+		result[s.Key] = s.Value
 	}
 	return result
 }
@@ -178,6 +176,13 @@ func (r *Registry) GetAllSettings() []PluginSettingsGroup {
 	return groups
 }
 
+// UpdateSetting saves a single plugin setting.
+func (r *Registry) UpdateSetting(pluginName, key, value string) {
+	r.db.Where("plugin_name = ? AND key = ?", pluginName, key).
+		Assign(PluginSetting{Value: value}).
+		FirstOrCreate(&PluginSetting{PluginName: pluginName, Key: key, Value: value})
+}
+
 // Middleware returns a Gin middleware that stores the registry on the context.
 func Middleware(registry *Registry) gin.HandlerFunc {
 	return func(c *gin.Context) {

plugin/registry_test.go

@@ -1,7 +1,6 @@
 package plugin_test
 
 import (
-	"goblog/blog"
 	"goblog/plugin"
 	"net/http"
 	"net/http/httptest"
@@ -43,7 +42,7 @@ func (p *testPlugin) TemplateData(ctx *plugin.HookContext) gin.H {
 
 func TestRegistryBasics(t *testing.T) {
 	db, _ := gorm.Open(sqlite.Open(":memory:"))
-	db.AutoMigrate(&blog.Setting{})
+	db.AutoMigrate(&plugin.PluginSetting{})
 
 	reg := plugin.NewRegistry(db)
 	tp := &testPlugin{}
@@ -59,7 +58,7 @@ func TestRegistryBasics(t *testing.T) {
 
 func TestRegistryInit(t *testing.T) {
 	db, _ := gorm.Open(sqlite.Open(":memory:"))
-	db.AutoMigrate(&blog.Setting{})
+	db.AutoMigrate(&plugin.PluginSetting{})
 
 	reg := plugin.NewRegistry(db)
 	reg.Register(&testPlugin{})
@@ -68,16 +67,16 @@ func TestRegistryInit(t *testing.T) {
 	}
 
 	// Check setting was seeded
-	var setting blog.Setting
-	db.Where("key = ?", "test.api_key").First(&setting)
+	var setting plugin.PluginSetting
+	db.Where("plugin_name = ? AND key = ?", "test", "api_key").First(&setting)
 	if setting.Value != "default123" {
 		t.Fatalf("expected default value 'default123', got %q", setting.Value)
 	}
 }
 
 func TestRegistryInjectTemplateData(t *testing.T) {
 	db, _ := gorm.Open(sqlite.Open(":memory:"))
-	db.AutoMigrate(&blog.Setting{})
+	db.AutoMigrate(&plugin.PluginSetting{})
 
 	reg := plugin.NewRegistry(db)
 	reg.Register(&testPlugin{})
@@ -121,7 +120,7 @@ func TestRegistryInjectTemplateData(t *testing.T) {
 
 func TestGetAllSettings(t *testing.T) {
 	db, _ := gorm.Open(sqlite.Open(":memory:"))
-	db.AutoMigrate(&blog.Setting{})
+	db.AutoMigrate(&plugin.PluginSetting{})
 
 	reg := plugin.NewRegistry(db)
 	reg.Register(&testPlugin{})

plugin/setting.go

@@ -0,0 +1,9 @@
+package plugin
+
+// PluginSetting stores a plugin's configuration in its own table,
+// separate from the blog's core Setting table.
+type PluginSetting struct {
+	PluginName string `gorm:"primaryKey" json:"plugin_name"`
+	Key        string `gorm:"primaryKey" json:"key"`
+	Value      string `json:"value"`
+}

www/js/admin-script.js

@@ -238,7 +238,7 @@ function togglePluginEnabled(checkbox) {
     // Save the enabled setting immediately
     var settings = [{"key": pluginName + ".enabled", "value": enabled, "type": "text"}];
     $.ajax({
-        url: "/api/v1/settings",
+        url: "/api/v1/plugin-settings",
         type: "patch",
         dataType: "json",
         contentType: "application/json",
@@ -275,7 +275,7 @@ function updatePluginSettings(btn) {
     });
 
     $.ajax({
-        url: "/api/v1/settings",
+        url: "/api/v1/plugin-settings",
         type: "patch",
         dataType: "json",
         contentType: "application/json",