Merge pull request #503 from compscidr/fix/tag-duplication-on-blur

Fix tag duplication on blur

Author: compscidr

admin/admin.go

@@ -187,8 +187,23 @@ func (a *Admin) UpdatePost(c *gin.Context) {
 		if err := tx.Model(&existingPost).Where("id = ?", requestPost.ID).Updates(&existingPost).Error; err != nil {
 			return err
 		}
+		// Filter empty/whitespace tag names, deduplicate, and ensure each exists in the DB
+		seen := make(map[string]bool)
+		var validTags []blog.Tag
+		for _, tag := range requestPost.Tags {
+			name := strings.TrimSpace(tag.Name)
+			if name == "" || seen[name] {
+				continue
+			}
+			seen[name] = true
+			var t blog.Tag
+			if err := tx.Where("name = ?", name).FirstOrCreate(&t, blog.Tag{Name: name}).Error; err != nil {
+				return err
+			}
+			validTags = append(validTags, t)
+		}
 		// Replace tag associations atomically to avoid duplication
-		if err := tx.Model(&existingPost).Association("Tags").Replace(requestPost.Tags); err != nil {
+		if err := tx.Model(&existingPost).Association("Tags").Replace(validTags); err != nil {
 			return err
 		}
 		//https://stackoverflow.com/questions/56653423/gorm-doesnt-update-boolean-field-to-false

tools/migrate.go

@@ -330,10 +330,26 @@ func Migrate(db *gorm.DB) error {
 	seedBacklinks(db)
 	seedDefaultPages(db)
 	linkWritingPagesToPostType(db)
+	cleanupEmptyTags(db)
 
 	return nil
 }
 
+// cleanupEmptyTags removes empty-name tag associations and the empty tag itself.
+func cleanupEmptyTags(db *gorm.DB) {
+	result := db.Exec("DELETE FROM post_tags WHERE tag_name = ''")
+	if result.Error != nil {
+		log.Printf("Warning: failed to clean up empty tag associations: %v", result.Error)
+		return
+	}
+	if result.RowsAffected > 0 {
+		log.Printf("Cleaned up %d empty tag associations", result.RowsAffected)
+	}
+	if err := db.Exec("DELETE FROM tags WHERE name = ''").Error; err != nil {
+		log.Printf("Warning: failed to clean up empty tag: %v", err)
+	}
+}
+
 // seedDefaultPages creates the default pages (Writing, Research, About) if no pages exist.
 func seedDefaultPages(db *gorm.DB) {
 	var count int64

www/js/admin-script.js

@@ -86,9 +86,9 @@ function uploadFile(fileInput) {
 
 function updatePost(id, publish) {
     var tags = $("#tags").text().split(',')
-    for (var i = 0; i < tags.length; i++) {
-        tags[i] = {"name": tags[i].trim()}
-    }
+        .map(function(t) { return t.trim(); })
+        .filter(function(t) { return t !== ""; })
+        .map(function(t) { return {"name": t}; });
     var time = $("#created_at").val();
     var vtime = moment.utc(time)
 
@@ -123,9 +123,9 @@ function updatePost(id, publish) {
 
 function createPost(publish) {
     var tags = $("#tags").val().split(',')
-    for (var i = 0; i < tags.length; i++) {
-        tags[i] = {"name": tags[i].trim()}
-    }
+        .map(function(t) { return t.trim(); })
+        .filter(function(t) { return t !== ""; })
+        .map(function(t) { return {"name": t}; });
 
     var time = $("#created_at").val();
     var vtime = moment.utc(time)