Skip to content

Get whole changeset for push events #1059

@wass3rw3rk

Description

@wass3rw3rk

Description

on push events, we currently get the file changeset for the first 100 entries1. in instances where users have a pipeline with a path: directive in their ruleset for this event and their change has 100+ files changed, it's possible that some files will be missed for consideration. for pull requests we currently page through the API responses to retrieve all changed files.

side note: it would require a larger change, but only making these requests when the pipeline somehow depends on it, would probably result in quite a reduction of unnecessary calls to GitHub. another thought, perhaps we can rely on the info in the payload which also shows files changed and only use the API if there are 100 entries (although the event payload itself seems to show more than that currently)?

Value

pipelines that cue off of large sets of file changes work as expected.

Definition of Done

a push event includes as complete of an inventory of files changed as github allows us to retrieve (even better, if it only does so when needed)

Effort (Optional)

Impacted Personas (Optional)

Footnotes

  1. https://github.com/go-vela/server/blob/0e450d5055d6b4d03f82e5b2fef1afc116e61b94/scm/github/changeset.go#L16-L42

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/serverIndicates a change to the serverenhancementIndicates an improvement to a feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions