-
Notifications
You must be signed in to change notification settings - Fork 3
Get whole changeset for push events #1059
Description
Description
on push events, we currently get the file changeset for the first 100 entries1. in instances where users have a pipeline with a path: directive in their ruleset for this event and their change has 100+ files changed, it's possible that some files will be missed for consideration. for pull requests we currently page through the API responses to retrieve all changed files.
side note: it would require a larger change, but only making these requests when the pipeline somehow depends on it, would probably result in quite a reduction of unnecessary calls to GitHub. another thought, perhaps we can rely on the info in the payload which also shows files changed and only use the API if there are 100 entries (although the event payload itself seems to show more than that currently)?
Value
pipelines that cue off of large sets of file changes work as expected.
Definition of Done
a push event includes as complete of an inventory of files changed as github allows us to retrieve (even better, if it only does so when needed)