Installer calls `apt` with wrong argument order

[Flamefire]

Bug reporting acknowledgment

Not applicable, Yes, I read it

Professional support

None

Describe the bug

The installer calls apt -y [install/purge], e.g. here:
https://github.com/glpi-project/glpi-agent/blob/ccbf107c647c62a9154ebf9ce27b755edbc6d48c/contrib/unix/installer/DebDistro.pm#L175C27-L175C39

However it needs to be e.g. apt install -y or the invocation will fail

To reproduce

sudo perl glpi-agent-1.15-linux-installer.pl --reinstall -v --typical

See output:

Found distro: Debian
Running on linux distro: Debian GNU/Linux bookworm/sid : Debian : bookworm/sid...
Disabling glpi-agent service...
Running: systemctl disable glpi-agent
Removed /etc/systemd/system/multi-user.target.wants/glpi-agent.service.
Uninstalling glpi-agent package...
Running: apt -y purge --autoremove glpi-agent 2>/dev/null

This is the Linux Mint "apt" command.

Expected behavior

Successful execution

Operating system

Linux

GLPI Agent version

v1.15

GLPI version

Not applicable

GLPIInventory plugin or other plugin version

No response

Additional context

No response

[g-bougard]

Hi @Flamefire

sorry for the late answer, but do you mean LinuxMint apt command beehives differently than Debian/Ubuntu one ? If yes, does it even use the same parameters ?

Actually, according to apt debian man page, it seems to me -y and --allow-downgrades should be placed before the command.

After some research, I found linuxmint apt version is 1.7.2 and current debian 3.0.3. It seems apt is finally not the right command to use on LinuxMint.

My advice is then to install glpi-agent manually using deb packages.

I saw also LinuxMint seems to use another package manager: aptkit. Maybe I can just update the installer to support this command. Can you advise me what we should do for LinuxMint ?

[Flamefire]

do you mean LinuxMint apt command beehives differently than Debian/Ubuntu one ? If yes, does it even use the same parameters ?

it looks like it, yes (to both)

However it seems to have changed by now: On Linux Mint 21.3 it works.

However IIRC you are not supposed to use apt for scripting but use apt-get directly. That might have a more stable CLI.

[g-bougard]

If I remember well, I used apt as I found it more powerful than apt-get for the purpose. Falling back on apt-get could be an update. I didn't expect a distro like LinuxMint decided to diverge so much.

[Flamefire]

For interactive use I fully agree, I never really type apt-get either ;-)
It e.g. (often) auto-uses sudo which you'd require for apt-get. But I remember warnings on CI that the CLI of apt is not stable and apt-get should be used for scripting. I guess this s what they meant by that.