chore: remove language role enum

Author: arrocke

src/modules/languages/actions/inviteLanguageMember.test.ts

@@ -4,7 +4,6 @@ import { test, expect } from "vitest";
 import { initializeDatabase } from "@/tests/vitest/dbUtils";
 import { EmailStatusRaw } from "@/modules/users/model/EmailStatus";
 import { UserStatusRaw } from "@/modules/users/model/UserStatus";
-import { LanguageMemberRoleRaw } from "../model";
 import { inviteLanguageMember } from "./inviteLanguageMember";
 import { createScenario, ScenarioDefinition } from "@/tests/scenarios";
 import { SystemRoleRaw } from "@/modules/users/model/SystemRole";
@@ -74,7 +73,6 @@ test("returns not found if not a platform admin", async () => {
   const formData = new FormData();
   formData.set("code", language.code);
   formData.set("email", "invite@example.com");
-  formData.set("roles[0]", LanguageMemberRoleRaw.Translator);
   const response = inviteLanguageMember({ state: "idle" }, formData);
   await expect(response).toBeNextjsNotFound();
 
@@ -89,7 +87,6 @@ test("returns not found if language does not exist", async () => {
   const formData = new FormData();
   formData.set("code", "garbage");
   formData.set("email", "invite@example.com");
-  formData.set("roles[0]", LanguageMemberRoleRaw.Translator);
   const response = inviteLanguageMember({ state: "idle" }, formData);
   await expect(response).toBeNextjsNotFound();
 });
@@ -101,12 +98,9 @@ test("adds existing user to the language", async () => {
   const language = scenario.languages.spanish;
   const user = await userFactory.build();
 
-  const role = LanguageMemberRoleRaw.Translator;
-
   const formData = new FormData();
   formData.set("code", language.code);
   formData.set("email", user.email);
-  formData.set("roles[0]", role);
   const response = inviteLanguageMember({ state: "idle" }, formData);
 
   await expect(response).toBeNextjsRedirect(
@@ -138,12 +132,10 @@ test("invites new user to the language", async () => {
   const language = scenario.languages.spanish;
 
   const email = "testinvite@example.com";
-  const role = LanguageMemberRoleRaw.Translator;
 
   const formData = new FormData();
   formData.set("code", language.code);
   formData.set("email", email);
-  formData.set("roles[0]", role);
   const response = inviteLanguageMember({ state: "idle" }, formData);
 
   await expect(response).toBeNextjsRedirect(

src/modules/languages/actions/removeLanguageMember.test.ts

@@ -3,7 +3,6 @@ import { ulid } from "@/shared/ulid";
 import { initializeDatabase } from "@/tests/vitest/dbUtils";
 import { expect, test } from "vitest";
 import { removeLanguageMember } from "./removeLanguageMember";
-import { LanguageMemberRoleRaw } from "../model";
 import { createScenario, ScenarioDefinition } from "@/tests/scenarios";
 import { SystemRoleRaw } from "@/modules/users/model/SystemRole";
 import logIn from "@/tests/vitest/login";

src/modules/languages/data-access/languageMemberRepository.test.ts

@@ -52,7 +52,6 @@ describe("create", () => {
       languageMemberRepository.create({
         languageId: language.id,
         userId: user.id,
-        roles: [],
       }),
     ).resolves.toBeUndefined();
 
@@ -74,7 +73,6 @@ describe("create", () => {
       languageMemberRepository.create({
         languageId: language.id,
         userId: ulid(),
-        roles: [],
       }),
     ).rejects.toThrowError(
       expect.objectContaining({
@@ -95,7 +93,6 @@ describe("create", () => {
       languageMemberRepository.create({
         languageId: ulid(),
         userId: user.id,
-        roles: [],
       }),
     ).rejects.toThrowError(
       expect.objectContaining({
@@ -115,7 +112,6 @@ describe("create", () => {
     await languageMemberRepository.create({
       languageId: language.id,
       userId: user.id,
-      roles: [],
     });
     const previousLanguageMembers = await getDb()
       .selectFrom("language_member")
@@ -126,7 +122,6 @@ describe("create", () => {
       languageMemberRepository.create({
         languageId: ulid(),
         userId: user.id,
-        roles: [],
       }),
     ).rejects.toThrowError(
       expect.objectContaining({

src/modules/languages/data-access/mockLanguageMemberRepository.ts

@@ -23,15 +23,6 @@ const mockLanguageMemberRepo = {
     this.members.push(member);
   },
 
-  async update(member: LanguageMember): Promise<void> {
-    const dbMember = this.members.find(
-      (m) => m.languageId === member.languageId && m.userId === member.userId,
-    );
-    if (!dbMember) return;
-
-    dbMember.roles = member.roles;
-  },
-
   async delete(languageId: string, userId: string): Promise<void> {
     this.members = this.members.filter(
       (m) => m.languageId !== languageId || m.userId !== userId,

src/modules/languages/data-access/types.ts

@@ -1,5 +1,5 @@
 import { Generated } from "kysely";
-import { LanguageMemberRoleRaw, TextDirectionRaw } from "../model";
+import { TextDirectionRaw } from "../model";
 
 export interface LanguageTable {
   id: Generated<string>;

src/modules/languages/model.ts

@@ -5,11 +5,6 @@ export enum TextDirectionRaw {
   RTL = "rtl",
 }
 
-export enum LanguageMemberRoleRaw {
-  Translator = "TRANSLATOR",
-  Admin = "ADMIN",
-}
-
 export class LanguageAlreadyExistsError extends Error {
   constructor(public code: string) {
     super();

src/modules/languages/public/LanguageClient.test.ts

@@ -1,6 +1,5 @@
 import { test, expect } from "vitest";
 import { initializeDatabase } from "@/tests/vitest/dbUtils";
-import { LanguageMemberRoleRaw } from "../model";
 import { languageClient } from "./LanguageClient";
 import { createScenario } from "@/tests/scenarios";
 import { findLanguageMembersForUser } from "../test-utils/dbUtils";

src/modules/languages/test-utils/factories.ts

@@ -1,9 +1,5 @@
 import { Async } from "factory.ts";
-import {
-  DbLanguage,
-  DbLanguageRole,
-  DbLanguageMember,
-} from "../data-access/types";
+import { DbLanguage, DbLanguageMember } from "../data-access/types";
 import { ulid } from "@/shared/ulid";
 import { faker } from "@faker-js/faker/locale/en";
 import localeMap from "@/data/locale-mapping.json";

src/modules/languages/use-cases/InviteLanguageMember.unit.ts

@@ -4,7 +4,7 @@ import mockLanguageRepo from "../data-access/mockLanguageRepository";
 import mockLanguageMemberRepo from "../data-access/mockLanguageMemberRepository";
 import fakeUserClient from "@/modules/users/public/FakeUserClient";
 import { NotFoundError } from "@/shared/errors";
-import { LanguageMemberRoleRaw, TextDirectionRaw } from "../model";
+import { TextDirectionRaw } from "../model";
 import { ulid } from "@/shared/ulid";
 
 const inviteLanguageMember = new InviteLanguageMember(
@@ -17,7 +17,6 @@ test("throws error if language could not be found", async () => {
   const response = inviteLanguageMember.execute({
     code: "spa",
     email: "invited@example.com",
-    roles: [],
   });
   await expect(response).rejects.toThrow(new NotFoundError("Language"));
 });
@@ -36,15 +35,13 @@ test("invites language member", async () => {
   const response = await inviteLanguageMember.execute({
     code: "spa",
     email: "invited@example.com",
-    roles: [LanguageMemberRoleRaw.Translator],
   });
   expect(response).toEqual({ userId: expect.toBeUlid() });
 
   expect(mockLanguageMemberRepo.members).toEqual([
     {
       languageId: language.id,
       userId: response.userId,
-      roles: [LanguageMemberRoleRaw.Translator],
     },
   ]);
 });

src/modules/languages/use-cases/RemoveLanguageMember.unit.ts

@@ -2,7 +2,7 @@ import { test, expect } from "vitest";
 import mockLanguageRepo from "../data-access/mockLanguageRepository";
 import mockLanguageMemberRepo from "../data-access/mockLanguageMemberRepository";
 import { NotFoundError } from "@/shared/errors";
-import { LanguageMemberRoleRaw, TextDirectionRaw } from "../model";
+import { TextDirectionRaw } from "../model";
 import { ulid } from "@/shared/ulid";
 import RemoveLanguageMember from "./RemoveLanguageMember";
 
@@ -31,7 +31,6 @@ test("removes language member", async () => {
   const languageMember = {
     languageId: language.id,
     userId: ulid(),
-    roles: [LanguageMemberRoleRaw.Translator],
   };
   mockLanguageRepo.languages = [language];
   mockLanguageMemberRepo.members = [languageMember];