Skip to content

Unregister on 'stop' #685

@jhmartin

Description

@jhmartin

https://github.com/gliderlabs/registrator/blob/master/registrator.go#L180-L184 indicates Registrator deregisters when a container exits. Clients of the service will have already received an error at that point. It'd be more graceful to mark the instance of the service as in maintenance mode concurrent with the 'stop' phase.

https://www.consul.io/api/agent/service.html#sample-request-4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions