You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix stale branch causing create_pull_request patch failures
Replace simple merge-from-main with reset-if-merged approach in Step 3
of the autoloop workflow. When a program branch's changes have already
been merged into main (git diff produces no output), the branch is reset
to origin/main instead of merging. This prevents format-patch from
generating patches with already-merged commits that cause git am failures.
Fixes #69
Agent-Logs-Url: https://github.com/githubnext/autoloop/sessions/1aea5829-61b7-4958-bf7e-56e7bd4f6d9d
Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Copy file name to clipboardExpand all lines: .github/workflows/autoloop.md
+6-3Lines changed: 6 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -644,11 +644,11 @@ Examples:
644
644
### How It Works
645
645
646
646
1. On the **first accepted iteration**, the branch is created from the default branch.
647
-
2. On **subsequent iterations**, the agent checks out the existing branch and ensures it is up to date with the default branch (by merging the default branch into it).
647
+
2. On **subsequent iterations**, the agent checks out the existing branch and ensures it is up to date with the default branch. If the branch's changes have already been merged into the default branch (i.e., `git diff origin/main..autoloop/{program-name}` is empty), the branch is **reset to `origin/main`** to avoid stale commits. Otherwise, the default branch is merged into it.
648
648
3.**Accepted iterations** are committed and pushed to the branch. Each commit message references the GitHub Actions run URL.
649
649
4.**Rejected or errored iterations** do not commit — changes are discarded.
650
650
5. A **single draft PR** is created for the branch on the first accepted iteration. Future accepted iterations push additional commits to the same PR.
651
-
6. The branch may be **merged into the default branch** at any time (by a maintainer or CI). After merging, the branch continues to be used for future iterations — it is never deleted while the program is active.
651
+
6. The branch may be **merged into the default branch** at any time (by a maintainer or CI). After merging, the branch continues to be used for future iterations — it is never deleted while the program is active. On the next iteration, the branch is automatically reset to the default branch (see step 2) so that already-merged commits do not cause patch conflicts.
652
652
7. A **sync workflow** automatically merges the default branch into all active `autoloop/*` branches whenever the default branch changes, keeping them up to date.
653
653
654
654
### Cross-Linking
@@ -691,7 +691,10 @@ Each run executes **one iteration for the single selected program**:
691
691
692
692
### Step 3: Implement
693
693
694
-
1. Check out the program's long-running branch `autoloop/{program-name}`. If the branch does not yet exist, create it from the default branch. If it does exist, ensure it is up to date with the default branch (merge the default branch into it).
694
+
1. Check out the program's long-running branch `autoloop/{program-name}`. If the branch does not yet exist, create it from the default branch. If it does exist:
695
+
- Fetch the default branch: `git fetch origin main`.
696
+
- Check whether the branch's changes have already been merged into main. If `git diff origin/main..autoloop/{program-name}` produces no output (i.e., every change on the branch is already on main), the branch is stale — **reset it to `origin/main`**: `git reset --hard origin/main`.
697
+
- Otherwise, merge the default branch into the long-running branch to pick up any upstream changes.
695
698
2. Make the proposed changes to the target files only.
696
699
3.**Respect the program constraints**: do not modify files outside the target list.
Copy file name to clipboardExpand all lines: workflows/autoloop.md
+6-3Lines changed: 6 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -719,11 +719,11 @@ Examples:
719
719
### How It Works
720
720
721
721
1. On the **first accepted iteration**, the branch is created from the default branch.
722
-
2. On **subsequent iterations**, the agent checks out the existing branch and ensures it is up to date with the default branch (by merging the default branch into it).
722
+
2. On **subsequent iterations**, the agent checks out the existing branch and ensures it is up to date with the default branch. If the branch's changes have already been merged into the default branch (i.e., `git diff origin/main..autoloop/{program-name}` is empty), the branch is **reset to `origin/main`** to avoid stale commits. Otherwise, the default branch is merged into it.
723
723
3.**Accepted iterations** are committed and pushed to the branch. Each commit message references the GitHub Actions run URL.
724
724
4.**Rejected or errored iterations** do not commit — changes are discarded.
725
725
5. A **single draft PR** is created for the branch on the first accepted iteration. Future accepted iterations push additional commits to the same PR.
726
-
6. The branch may be **merged into the default branch** at any time (by a maintainer or CI). After merging, the branch continues to be used for future iterations — it is never deleted while the program is active.
726
+
6. The branch may be **merged into the default branch** at any time (by a maintainer or CI). After merging, the branch continues to be used for future iterations — it is never deleted while the program is active. On the next iteration, the branch is automatically reset to the default branch (see step 2) so that already-merged commits do not cause patch conflicts.
727
727
7. A **sync workflow** automatically merges the default branch into all active `autoloop/*` branches whenever the default branch changes, keeping them up to date.
728
728
729
729
### Cross-Linking
@@ -766,7 +766,10 @@ Each run executes **one iteration for the single selected program**:
766
766
767
767
### Step 3: Implement
768
768
769
-
1. Check out the program's long-running branch `autoloop/{program-name}`. If the branch does not yet exist, create it from the default branch. If it does exist, ensure it is up to date with the default branch (merge the default branch into it).
769
+
1. Check out the program's long-running branch `autoloop/{program-name}`. If the branch does not yet exist, create it from the default branch. If it does exist:
770
+
- Fetch the default branch: `git fetch origin main`.
771
+
- Check whether the branch's changes have already been merged into main. If `git diff origin/main..autoloop/{program-name}` produces no output (i.e., every change on the branch is already on main), the branch is stale — **reset it to `origin/main`**: `git reset --hard origin/main`.
772
+
- Otherwise, merge the default branch into the long-running branch to pick up any upstream changes.
770
773
2. Make the proposed changes to the target files only.
771
774
3.**Respect the program constraints**: do not modify files outside the target list.
0 commit comments