Safe Output Health Report - 2026-04-01 #23896
Closed
Replies: 1 comment
-
|
This discussion has been marked as outdated by Safe Output Health Monitor. A newer discussion is available at Discussion #24113. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Executive Summary
Both failures occurred in the Smoke Claude workflow and share the same root cause: the agent generates run-specific filenames for push tests, but the
push_to_pull_request_branchconfig only allows.github/smoke-claude-push-test.md.Safe Output Job Statistics
Message-level breakdown (from completed safe-output-items):
Error Clusters
Cluster 1:
push_to_pull_request_branch— Files Outside Allowed-Files Listpush_to_pull_request_branch.smoke,.json) to verify push capability, but thepush_to_pull_request_branchhandler config restricts pushes to onlyallowed_files: [".github/smoke-claude-push-test.md"]. The filenames differ across runs.push_to_pull_request_branchfailure cancels all subsequent safe output messages:create_issue+add_labelscancelled (2 messages)create_issuecancelled (1 message)Cascading Cancellation Details
Run 23847925954 — 11 messages total, 6 succeeded before failure:
Run 23848854083 — 9 messages total, 7 succeeded before failure:
Root Cause Analysis
Config/Agent Mismatch in Smoke Claude Push Tests
The Smoke Claude workflow is designed to test the end-to-end
push_to_pull_request_branchsafe output flow. However, there is a mismatch between:allowed_files: [".github/smoke-claude-push-test.md"]smoke-test-pr-push-<run_id>.smokeandtest-smoke-<run_id>.jsonThe agent appears to be generating ephemeral test files with run-specific names rather than using the whitelisted fixed filename. This is a new pattern first observed today (not seen in previous audits).
Distinct from 2026-03-31 issue: The previous
push_to_pull_request_branchfailure was a "missing remote branch" error (fatal: couldn't find remote ref pr-branch). Today's pattern is a different enforcement — the branch exists, but the file contents are blocked by the allowed-files filter.Recommendations
Critical Issues (Immediate Action Required)
None — the failures are contained to Smoke Claude test runs and do not affect production workflows. Other safe output messages continue to process successfully before the push failure.
Bug Fixes Required
Fix 1: Smoke Claude Agent Prompt — Use Whitelisted Filename for Push Tests
smoke-test-pr-push-<run_id>.smoke,test-smoke-<run_id>.json) for push tests instead of the configured allowed file.github/smoke-claude-push-test.md.github/smoke-claude-push-test.mdwhen testingpush_to_pull_request_branchpush_to_pull_request_branchFix 2 (Alternative): Update
allowed_filesConfig to Accept Test Filespush_to_pull_request_branchhandler configallowed_fileslist is too narrow for smoke tests that generate dynamic filenamesallowed_filesto accommodate smoke test files (e.g.,smoke-test-*.smoke,test-smoke-*.json), OR add a dedicated smoke test directoryWork Item Plans
Work Item 1: Fix Smoke Claude Push Test Filename
push_to_pull_request_branchconfig only whitelists.github/smoke-claude-push-test.md. This causes 100% failure rate on push tests.push_to_pull_request_branchsucceeds in smoke test runs.github/smoke-claude-push-test.mdas the push test file, ORallowed_filesis updated to include the generated patterncreate_issue/add_labelsdue to push failuresHistorical Context
invalid_event_context(target=triggering on scheduled runs),protected-files-pr-block,upload-assets-missing-setupinvalid_event_context(recurring),add_labels_no_issue_numberpush_to_pull_request_branch: missing remote branchpush_to_pull_request_branch: files outside allowed-files list (new)Trends
invalid_event_contextandadd_labels_no_issue_numberhave not recurred since 2026-03-30push_to_pull_request_branchfailing due to filename mismatch in Smoke Claude (2 occurrences)Metrics and KPIs
add_comment,create_discussion,create_pull_request_review_comment— 100% successpush_to_pull_request_branch— 0% success (2/2 failures, both Smoke Claude)Next Steps
push_to_pull_request_branchfilename mismatchReferences:
Beta Was this translation helpful? Give feedback.
All reactions