refactor: improve variable naming in isThreatDetectionExplicitlyDisabledInConfigs

Copilot · szabta89 · web-flow · commit 232b76373217 · 2026-04-02T19:11:59.000Z
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/04d5841d-b6e2-4420-84a8-f1645236c51d Co-authored-by: szabta89 <1330202+szabta89@users.noreply.github.com>
diff --git a/pkg/workflow/threat_detection.go b/pkg/workflow/threat_detection.go
@@ -50,7 +50,9 @@ func isThreatDetectionExplicitlyDisabledInConfigs(configs []string) bool {
 			continue
 		}
 		if tdVal, exists := config["threat-detection"]; exists {
-			if disabled, ok := tdVal.(bool); ok && !disabled {
+			// tdBool is the raw bool value of the threat-detection key.
+			// When threat-detection: false, tdBool == false, so !tdBool == true → disabled.
+			if tdBool, ok := tdVal.(bool); ok && !tdBool {
 				return true
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,9 @@ func isThreatDetectionExplicitlyDisabledInConfigs(configs []string) bool {`
`50`	`50`	`continue`
`51`	`51`	`}`
`52`	`52`	`if tdVal, exists := config["threat-detection"]; exists {`
`53`		`- if disabled, ok := tdVal.(bool); ok && !disabled {`
	`53`	`+ // tdBool is the raw bool value of the threat-detection key.`
	`54`	`+ // When threat-detection: false, tdBool == false, so !tdBool == true → disabled.`
	`55`	`+ if tdBool, ok := tdVal.(bool); ok && !tdBool {`
`54`	`56`	`return true`
`55`	`57`	`}`
`56`	`58`	`}`