Commit 97784a4
authored
Fix workflow documentation to use dynamic workspace paths (#879)
The Language Support Tester workflow documentation hardcoded
`/workspace/` paths, preventing the agent from locating test samples at
runtime. GitHub Actions workspace paths vary by environment (e.g.,
`/home/runner/work/{repo}/{repo}`).
## Changes
- **Updated path references in
`.github/agentics/language-support-tester.md`**:
- Changed hardcoded `/workspace/` paths to `{workspace}` placeholder
- Added instructions to use workspace path from `github-context` section
- Applied to JavaScript/TypeScript test samples path
- Applied to Python test samples path
- Updated "Important Notes" section references
The agent now receives the actual runtime workspace path via
`__GH_AW_GITHUB_WORKSPACE__` in the github-context and can correctly
construct paths to test samples:
```markdown
- Use the test samples at `{workspace}/test/serena-mcp-tests/samples/js_project/` (use the workspace path from github-context)
```
## Notes
Test sample files already exist in the repository with expected content
(`Calculator` class, `add` method, `format_number` function,
`package.json`). No code changes required.
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `example.com`
> - Triggering command: `/tmp/go-build380999041/b279/launcher.test
/tmp/go-build380999041/b279/launcher.test
-test.testlogfile=/tmp/go-build380999041/b279/testlog.txt
-test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo
HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64
/usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build
Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config
x_amd64/vet` (dns block)
> - `invalid-host-that-does-not-exist-12345.com`
> - Triggering command: `/tmp/go-build380999041/b264/config.test
/tmp/go-build380999041/b264/config.test
-test.testlogfile=/tmp/go-build380999041/b264/testlog.txt
-test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/c-c=4
kdf/cast.go ache/go/1.25.6/x-importcfg cal/bin/git base64 /usr/sbin/git
6.o -c 64/src/runtime/cgo tf "%s%s", sep, $0; sep=RS }
x_amd64/compile --abbrev-ref HEAD /usr/bin/base64 x_amd64/compile` (dns
block)
> - `nonexistent.local`
> - Triggering command: `/tmp/go-build380999041/b279/launcher.test
/tmp/go-build380999041/b279/launcher.test
-test.testlogfile=/tmp/go-build380999041/b279/testlog.txt
-test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo
HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64
/usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build
Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config
x_amd64/vet` (dns block)
> - `slow.example.com`
> - Triggering command: `/tmp/go-build380999041/b279/launcher.test
/tmp/go-build380999041/b279/launcher.test
-test.testlogfile=/tmp/go-build380999041/b279/testlog.txt
-test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo
HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64
/usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build
Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config
x_amd64/vet` (dns block)
> - `this-host-does-not-exist-12345.com`
> - Triggering command: `/tmp/go-build380999041/b288/mcp.test
/tmp/go-build380999041/b288/mcp.test
-test.testlogfile=/tmp/go-build380999041/b288/testlog.txt
-test.paniconexit0 -test.timeout=10m0s -test.v=true 737903/b083/_pkg_.a
JWKP/08bK8wSDgKwIadp3JWKP x_amd64/vet cal/bin/git /unix /x64=/_/GOROOT
x_amd64/vet o_.o�� ache/go/1.25.6/x-errorsas
ache/go/1.25.6/x-ifaceassert x_amd64/vet 737903/b083/symabash HEAD
ndor/bin/git x_amd64/vet` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/github/gh-aw-mcpg/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
>
> ----
>
> *This section details on the original issue you should resolve*
>
> <issue_title>[language-support] Missing test samples for
TypeScript/JavaScript and Python language support testing</issue_title>
> <issue_description>## Summary
>
> The Language Support Tester workflow references test sample
directories that do not exist in the repository, preventing proper
testing of TypeScript/JavaScript and Python language support with the
Serena MCP server.
>
> ## Missing Directories
>
> The following test sample directories referenced in
`.github/agentics/language-support-tester.md` are missing:
>
> - `/workspace/test/serena-mcp-tests/samples/js_project/`
> - `/workspace/test/serena-mcp-tests/samples/python_project/`
>
> ## Impact
>
> - **Go language support**: ✅ Successfully tested with existing Go
files
> - **TypeScript/JavaScript support**: ❌ Cannot test - no test samples
exist
> - **Python support**: ❌ Cannot test - no test samples exist
>
> ## Test Results
>
> ### Go Language Support (✅ Working)
>
> Successfully tested Go language support using the main repository
code:
> - `get_symbols_overview` on `main.go` returned functions: `main`,
`buildVersionString`, and constant `shortHashLength`
> - `find_symbol` successfully found the `main` function with correct
location and signature
> - `find_symbol` successfully found the `Version` variable in
`version.go` with complete info including documentation
>
> ### TypeScript/JavaScript Support (1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
75 | | - | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
0 commit comments