Skip to content

Commit 97784a4

Browse files
authored
Fix workflow documentation to use dynamic workspace paths (#879)
The Language Support Tester workflow documentation hardcoded `/workspace/` paths, preventing the agent from locating test samples at runtime. GitHub Actions workspace paths vary by environment (e.g., `/home/runner/work/{repo}/{repo}`). ## Changes - **Updated path references in `.github/agentics/language-support-tester.md`**: - Changed hardcoded `/workspace/` paths to `{workspace}` placeholder - Added instructions to use workspace path from `github-context` section - Applied to JavaScript/TypeScript test samples path - Applied to Python test samples path - Updated "Important Notes" section references The agent now receives the actual runtime workspace path via `__GH_AW_GITHUB_WORKSPACE__` in the github-context and can correctly construct paths to test samples: ```markdown - Use the test samples at `{workspace}/test/serena-mcp-tests/samples/js_project/` (use the workspace path from github-context) ``` ## Notes Test sample files already exist in the repository with expected content (`Calculator` class, `add` method, `format_number` function, `package.json`). No code changes required. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `example.com` > - Triggering command: `/tmp/go-build380999041/b279/launcher.test /tmp/go-build380999041/b279/launcher.test -test.testlogfile=/tmp/go-build380999041/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64 /usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config x_amd64/vet` (dns block) > - `invalid-host-that-does-not-exist-12345.com` > - Triggering command: `/tmp/go-build380999041/b264/config.test /tmp/go-build380999041/b264/config.test -test.testlogfile=/tmp/go-build380999041/b264/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/c-c=4 kdf/cast.go ache/go/1.25.6/x-importcfg cal/bin/git base64 /usr/sbin/git 6.o -c 64/src/runtime/cgo tf &#34;%s%s&#34;, sep, $0; sep=RS } x_amd64/compile --abbrev-ref HEAD /usr/bin/base64 x_amd64/compile` (dns block) > - `nonexistent.local` > - Triggering command: `/tmp/go-build380999041/b279/launcher.test /tmp/go-build380999041/b279/launcher.test -test.testlogfile=/tmp/go-build380999041/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64 /usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config x_amd64/vet` (dns block) > - `slow.example.com` > - Triggering command: `/tmp/go-build380999041/b279/launcher.test /tmp/go-build380999041/b279/launcher.test -test.testlogfile=/tmp/go-build380999041/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64 /usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config x_amd64/vet` (dns block) > - `this-host-does-not-exist-12345.com` > - Triggering command: `/tmp/go-build380999041/b288/mcp.test /tmp/go-build380999041/b288/mcp.test -test.testlogfile=/tmp/go-build380999041/b288/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 737903/b083/_pkg_.a JWKP/08bK8wSDgKwIadp3JWKP x_amd64/vet cal/bin/git /unix /x64=/_/GOROOT x_amd64/vet o_.o�� ache/go/1.25.6/x-errorsas ache/go/1.25.6/x-ifaceassert x_amd64/vet 737903/b083/symabash HEAD ndor/bin/git x_amd64/vet` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/github/gh-aw-mcpg/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[language-support] Missing test samples for TypeScript/JavaScript and Python language support testing</issue_title> > <issue_description>## Summary > > The Language Support Tester workflow references test sample directories that do not exist in the repository, preventing proper testing of TypeScript/JavaScript and Python language support with the Serena MCP server. > > ## Missing Directories > > The following test sample directories referenced in `.github/agentics/language-support-tester.md` are missing: > > - `/workspace/test/serena-mcp-tests/samples/js_project/` > - `/workspace/test/serena-mcp-tests/samples/python_project/` > > ## Impact > > - **Go language support**: ✅ Successfully tested with existing Go files > - **TypeScript/JavaScript support**: ❌ Cannot test - no test samples exist > - **Python support**: ❌ Cannot test - no test samples exist > > ## Test Results > > ### Go Language Support (✅ Working) > > Successfully tested Go language support using the main repository code: > - `get_symbols_overview` on `main.go` returned functions: `main`, `buildVersionString`, and constant `shortHashLength` > - `find_symbol` successfully found the `main` function with correct location and signature > - `find_symbol` successfully found the `Version` variable in `version.go` with complete info including documentation > > ### TypeScript/JavaScript Support (⚠️ Unable to Test) > > The referenced test directory `/workspace/test/serena-mcp-tests/samples/js_project/` does not exist. The repository contains no JavaScript or TypeScript files for testing. > > ### Python Support (⚠️ Unable to Test) > > The referenced test directory `/workspace/test/serena-mcp-tests/samples/python_project/` does not exist. The repository contains no Python files for testing. > > ## Reproduction Steps > > 1. Run the Language Support Tester workflow > 2. Agent attempts to locate test samples at the documented paths > 3. Paths do not exist in the repository > > ## Recommended Solution > > Create the missing test sample directories with appropriate test files: > > 1. Create `/workspace/test/serena-mcp-tests/samples/js_project/` with: > - `index.js` or `index.ts` with sample functions/classes > - `package.json` with project metadata > > 2. Create `/workspace/test/serena-mcp-tests/samples/python_project/` with: > - `calculator.py` with a `Calculator` class and `add` method > - `utils.py` with utility functions like `format_number` > > Alternatively, update the testing workflow documentation to reference existing test files or clarify that only Go language support needs testing. > > ## Additional Context > > - Serena MCP server version: `ghcr.io/github/serena-mcp-server:latest` > - Workflow: `.github/workflows/language-support-tester.lock.yml` > - Task specification: `.github/agentics/language-support-tester.md` > - Active project: `gh-aw-mcpg` (Go language configured) > > > > > > AI generated by [Language Support Tester](https://github.com/github/gh-aw-mcpg/actions/runs/21861851918) > > - [x] expires <!-- gh-aw-expires: 2026-02-17T10:55:01.059Z --> on Feb 17, 2026, 10:55 AM UTC > > <!-- gh-aw-agentic-workflow: Language Support Tester, engine: copilot, run: https://github.com/github/gh-aw-mcpg/actions/runs/21861851918 --> > > <!-- gh-aw-workflow-id: language-support-tester --></issue_description> > > ## Comments on the Issue (you are @claude[agent] in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #875
2 parents 238e302 + 852a516 commit 97784a4

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

.github/agentics/language-support-tester.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Test that Go, TypeScript/JavaScript, and Python programming language support wor
2121
## Step 2: Test TypeScript/JavaScript Language Support
2222

2323
1. **Activate a TypeScript/JavaScript project** using Serena's `activate_project` tool
24-
- Use the test samples at `/workspace/test/serena-mcp-tests/samples/js_project/`
24+
- Use the test samples at `{workspace}/test/serena-mcp-tests/samples/js_project/` (use the workspace path from github-context)
2525
2. **Verify TypeScript/JavaScript tooling works**:
2626
- Use Serena to analyze JavaScript/TypeScript files
2727
- Try to find functions or symbols in the JavaScript code
@@ -31,7 +31,7 @@ Test that Go, TypeScript/JavaScript, and Python programming language support wor
3131
## Step 3: Test Python Language Support
3232

3333
1. **Activate a Python project** using Serena's `activate_project` tool with the Python language
34-
- Use the test samples at `/workspace/test/serena-mcp-tests/samples/python_project/`
34+
- Use the test samples at `{workspace}/test/serena-mcp-tests/samples/python_project/` (use the workspace path from github-context)
3535
2. **Verify Python tooling works**:
3636
- Use Serena to analyze Python files (`calculator.py`, `utils.py`)
3737
- Try to find functions, classes, or symbols in Python code (e.g., `Calculator` class, `add` method, `format_number` function)
@@ -70,9 +70,9 @@ Test that Go, TypeScript/JavaScript, and Python programming language support wor
7070
## Important Notes
7171

7272
- This workflow tests the Serena MCP server container specified in the repository configuration
73-
- The Go project is the main repository code in `/workspace`
74-
- TypeScript/JavaScript test samples are located at `/workspace/test/serena-mcp-tests/samples/js_project/`
75-
- Python test samples are located at `/workspace/test/serena-mcp-tests/samples/python_project/`
73+
- The Go project is the main repository code in the workspace directory (see workspace path in github-context)
74+
- TypeScript/JavaScript test samples are located at `{workspace}/test/serena-mcp-tests/samples/js_project/` (use the workspace path from github-context)
75+
- Python test samples are located at `{workspace}/test/serena-mcp-tests/samples/python_project/` (use the workspace path from github-context)
7676
- Issues created will automatically expire after 7 days if not addressed
7777
- Focus on testing actual language server functionality, not just basic container operations
7878
- Serena uses "typescript" as the language identifier for both JavaScript and TypeScript files

0 commit comments

Comments
 (0)