Merge pull request #1 from gitclear/prepare-gem-for-gitclear

Prepare gem for gitclear.

Author: codrin-mares

.github/workflows/rubocop.yml

@@ -1,29 +1,17 @@
 name: PostgreSQL
-on: [pull_request]
+on: [push]
 jobs:
   Test-With-PostgreSQL:
     runs-on: ubuntu-latest
-    container: ruby:${{ matrix.ruby }}
+    container: ruby:3.2
     strategy:
       fail-fast: false
-      matrix:
-        active_record: [6.1.7.2, 6.0.6, 5.2.8.1]
-        ruby: ['3.0', 3.1, 3.2]
-        exclude:
-          - active_record: 5.2.8.1
-            ruby: '3.0'
-          - active_record: 5.2.8.1
-            ruby: 3.1
-          - active_record: 5.2.8.1
-            ruby: 3.2
     env:
-      ACTIVE_RECORD_VERSION: ${{ matrix.active_record }}
       DATABASE_ADAPTER: postgresql
-      INSTALL_PG_GEM: true
       RAILS_ENV: test
     services:
       postgres:
-        image: postgres
+        image: postgres:14
         env:
           POSTGRES_PASSWORD: postgres
         options: >-

.github/workflows/test-with-mysql.yml

@@ -1,13 +1,10 @@
-FROM ruby:3.1
+FROM ruby:3.2
 
 ENV APP_HOME /activerecord_cte
 RUN mkdir $APP_HOME
 WORKDIR $APP_HOME
 
 ENV RAILS_ENV test
-ENV INSTALL_MYSQL_GEM true
-ENV INSTALL_PG_GEM true
-ENV MYSQL_HOST mysql
 
 # Cache the bundle install
 COPY Gemfile* $APP_HOME/

.github/workflows/test-with-postgresql.yml

@@ -5,11 +5,8 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in activerecord-cte.gemspec
 gemspec
 
-ACTIVE_RECORD_VERSION = ENV.fetch("ACTIVE_RECORD_VERSION", "6.1.7.2")
+gem "pg"
 
-gem "activerecord", ACTIVE_RECORD_VERSION
-
-gem "mysql2" if ENV["INSTALL_MYSQL_GEM"]
-gem "pg" if ENV["INSTALL_PG_GEM"]
-
-gem "sqlite3", "1.7.3"
+group :development, :test do
+  gem "activerecord", "6.1.7.9"
+end

.github/workflows/test-with-sqlite.yml

@@ -94,6 +94,32 @@ Post.with("posts_with_tags AS (SELECT * FROM posts WHERE tags_count > 0)")
 # SELECT * FROM posts
 ```
 
+#### Enhanced String CTE Parsing
+
+This gem includes robust string CTE parsing that handles various table name formats and provides detailed error messages. It supports:
+
+- **Quoted table names**: `` `table_name` ``, `"table_name"`
+- **Unquoted table names**: `table_name`, `user_posts`, `table_2023`
+- **Case-insensitive AS keyword**: `AS`, `as`, `As`
+- **Complex SQL expressions**: Nested parentheses, subqueries, etc.
+- **Comprehensive validation**: Balanced parentheses, empty components, malformed syntax
+
+```ruby
+# All of these work:
+Post.with("`quoted_table` AS (SELECT * FROM posts)")
+Post.with('"double_quoted" AS (SELECT * FROM posts)')
+Post.with("users_with_posts AS (SELECT * FROM posts WHERE id IN (SELECT post_id FROM comments))")
+Post.with("popular_posts as (SELECT * FROM posts WHERE views > 1000)") # lowercase 'as'
+```
+
+If there's a syntax error, you'll get helpful error messages:
+- `"CTE string cannot be empty"`
+- `"CTE string must contain 'AS' keyword. Expected 'table_name AS (SELECT ...)' but got: ..."`
+- `"CTE expression must be enclosed in parentheses. Expected 'table_name AS (SELECT ...)' but got: ..."`
+- `"Unbalanced parentheses in CTE expression: ..."`
+
+This parsing capability provides a workaround for Rails 6.1+ where string CTE support was broken (see [Rails PR #42563](https://github.com/rails/rails/pull/42563) which was rejected). The implementation is fully documented in `lib/activerecord/cte/string_cte_parser.rb`.
+
 ### Arel Nodes
 
 If you already have `Arel::Node::As` node you can just pass it as is
@@ -214,6 +240,9 @@ bundle exec rubocop
 To run the tests using SQLite adapter and latest version on Rails run
 
 ```
+POSTGRES_USER={your_pg_user} \
+POSTGRES_PASSWORD={your_pg_password} \
+POSTGRES_HOST=localhost \
 bundle exec rake test
 ```
 

Dockerfile

@@ -34,10 +34,10 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "pg", "~> 1.5.6"
   spec.add_development_dependency "rake", "~> 13.0.1"
-  spec.add_development_dependency "rubocop", "~> 1.17.0"
-  spec.add_development_dependency "rubocop-minitest", "~> 0.13.0"
-  spec.add_development_dependency "rubocop-performance", "~> 1.11.3"
-  spec.add_development_dependency "rubocop-rake", "~> 0.5.1"
-  spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "rubocop", "~> 1.53.0"
+  spec.add_development_dependency "rubocop-minitest", "~> 0.30.0"
+  spec.add_development_dependency "rubocop-performance", "~> 1.19.0"
+  spec.add_development_dependency "rubocop-rake", "~> 0.6.0"
 end

Gemfile

@@ -4,8 +4,8 @@
 require "English"
 require "yaml"
 
-active_record_versions = %w[6.1.7.2 6.0.6]
-database_adapters = %w[mysql postgresql sqlite3]
+active_record_versions = %w[6.1.7.9]
+database_adapters = %w[postgresql]
 
 class Matrix
   def initialize(active_record_versions, database_adapters)

README.md

@@ -4,27 +4,12 @@ services:
   lib:
     build: .
     links:
-      - mysql
       - postgres
     volumes:
       - ".:/activerecord_cte"
 
-  mysql:
-    image: mysql:8.0
-    command: mysqld --default-authentication-plugin=mysql_native_password --skip-mysqlx
-    restart: always
-    environment:
-      MYSQL_DATABASE: activerecord_cte_test
-      MYSQL_USER: root
-      MYSQL_PASSWORD: root
-      MYSQL_ROOT_PASSWORD: root
-    ports:
-      - 3306:3306
-    expose:
-      - 3306
-
   postgres:
-    image: postgres:12
+    image: postgres:14
     restart: always
     environment:
       POSTGRES_DB: activerecord_cte_test