Add HttpRequest fluent builder

Author: ggcr

src/s3cpp/httpclient.cpp

@@ -5,9 +5,7 @@
 #include <stdexcept>
 #include <string>
 
-HttpResponse HttpRequest::execute() {
-	return client_.execute(*this);
-}
+HttpResponse HttpRequest::execute() { return client_.execute(*this); }
 
 HttpResponse HttpClient::execute(HttpRequest &request) {
   if (!curl_handle) {

src/s3cpp/httpclient.h

@@ -14,7 +14,7 @@ class HttpResponse {
 public:
   HttpResponse(int c, std::string b) : code_(c), body_(std::move(b)) {};
 
-  [[nodiscard]] int status() const { return code_; }
+  int status() const { return code_; }
   const std::string &body() const { return body_; }
 
   bool is_ok() const { return code_ >= 200 && code_ < 300; }
@@ -33,7 +33,7 @@ class HttpRequest {
   HttpRequest(HttpClient &client, std::string URL)
       : client_(client), URL_(std::move(URL)), timeout_(0) {};
 
-  [[nodiscard]] HttpRequest &header(const std::string &header,
+  [[nodiscard]] HttpRequest &header(const std::string &&header,
                                     const std::string &value) {
     headers_[header] = value;
     return *this;
@@ -43,16 +43,16 @@ class HttpRequest {
     return *this;
   }
 
-	HttpResponse execute();
+  HttpResponse execute();
 
-	std::string getURL() {return URL_;}
-	int getTimeout() {return timeout_;}
+  const std::string& getURL() const { return URL_; }
+  const int getTimeout() const { return timeout_; }
 
 private:
   HttpClient &client_;
   std::string URL_;
   std::unordered_map<std::string, std::string> headers_;
-  int timeout_;
+  int timeout_; // TODO(cristian): `std::chrono` ?
 };
 
 // HttpClient should only focus on handling the cURL handle

test/httpclient_test.cpp

@@ -56,13 +56,14 @@ TEST(HTTP, HTTPBodyNonEmpty) {
 }
 
 TEST(HTTP, HTTPHandleTimeout) {
-	HttpClient client{};
+  HttpClient client{};
   try {
-    auto response = client.get("https://postman-echo.com/delay/10")
-			.timeout(1)
-			.execute();
-		FAIL () << "Client not handling 1s timeout on a 10s delayed request";
+    auto response =
+        client.get("https://postman-echo.com/delay/10").timeout(1).execute();
+    FAIL() << "Client not handling 1s timeout on a 10s delayed request";
   } catch (const std::exception &e) {
-		SUCCEED(); // libcurl error for request: Timeout was reached
+    SUCCEED(); // libcurl error for request: Timeout was reached
   }
 }
+
+// TODO(cristian): Headers extensive tests