Skip to content

parameters deep in source code #47

@Jintram

Description

@Jintram

e.g. drawTime function in 3DRadInf function has following lines to straddle time:

Real low(1e-100);
Real high(100);

(..)

const gsl_root_fsolver_type* solverType(gsl_root_fsolver_brent);
gsl_root_fsolver* solver(gsl_root_fsolver_alloc(solverType));
gsl_root_fsolver_set(solver, &F, low, high);

const unsigned int maxIter(100);

unsigned int i(0);
for (;;)
{
    gsl_root_fsolver_iterate(solver);

    low = gsl_root_fsolver_x_lower(solver);
    high = gsl_root_fsolver_x_upper(solver);
    int status(gsl_root_test_interval(low, high, 1e-18, 1e-12));

That "low" and "high" parameter should perhaps be re-allocated to hpp file, since they're dependent on the scale we're looking at.

(Put it in issue tracker to remember to look at this in general. Didn't fix it as it works for now.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions