Skip to content

feat: add conversion ID support #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yihao-G merged 1 commit into from
Jan 30, 2026
Merged

feat: add conversion ID support #14

Yihao-G merged 1 commit into from
Jan 30, 2026

Conversation

@Yihao-G
Copy link
Contributor

@Yihao-G Yihao-G commented Jan 8, 2026 •
edited
Loading

https://linear.app/makevero/issue/ENG-702/update-trackingjs-sdk-to-handle-vero-conv-query-param-for-conversion

Description

Implemented conversion tracking by reading the vero_conv value from the URL's query param and attach it to the following tracked events' extras object.

Checklist

  • My PR represents one logical piece of work
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation - Corresponding JSDocs updated
  • I have added tests that prove my fix is effective or that my feature works

@Yihao-G Graphite App
Copy link
Contributor Author

Yihao-G commented Jan 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@macroscopeapp
Copy link

macroscopeapp bot commented Jan 8, 2026 •
edited
Loading

Add conversion ID support by capturing vero_conv in browser via SessionStorageConversionIdStore and LegacySessionCookieConversionIdStore and conditionally including it in tracker.Tracker.sendEventTrackRequest extras

Introduce ConversionIdStore with sessionStorage and session cookie implementations, add getVeroConvParam, and update tracker.Tracker to source vero_conv from request.extras.veroConv or the store.

📍Where to Start

Start with the default store initialization and payload inclusion logic in tracker.Tracker constructor and sendEventTrackRequest in tracker.ts.

Macroscope summarized f3e6248.

@Yihao-G Yihao-G force-pushed the feature/feat_add_conversion_id_support branch 2 times, most recently from 8b37faa to 9e17d74 Compare January 8, 2026 05:17
macroscopeapp[bot]
macroscopeapp bot reviewed Jan 8, 2026
View reviewed changes
@Yihao-G Yihao-G force-pushed the feature/feat_add_conversion_id_support branch 2 times, most recently from 4c6e1fc to 5302287 Compare January 8, 2026 05:49
macroscopeapp[bot]
macroscopeapp bot reviewed Jan 8, 2026
View reviewed changes
@Yihao-G Yihao-G force-pushed the feature/feat_add_conversion_id_support branch 3 times, most recently from 3898b92 to 0b2b665 Compare January 8, 2026 06:30
macroscopeapp[bot]
macroscopeapp bot reviewed Jan 8, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🎉 Package published successfully!

📦 Package: @getvero/tracking
📌 Version: 0.0.0-alpha.20260108-0b2b665

You can install this version using:

npm install @getvero/tracking@0.0.0-alpha.20260108-0b2b665

@Yihao-G Yihao-G marked this pull request as ready for review January 9, 2026 00:36
@Yihao-G Yihao-G requested a review from hui January 9, 2026 00:36
@Yihao-G Yihao-G force-pushed the feature/feat_add_conversion_id_support branch 2 times, most recently from 04526e5 to e0b456c Compare January 9, 2026 01:01
@Yihao-G Yihao-G requested a review from andrewobrien January 27, 2026 23:36
andrewobrien
andrewobrien approved these changes Jan 29, 2026
View reviewed changes
Copy link

@andrewobrien andrewobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @Yihao-G one minor suggestion is we could also validate options.cookieDomain before setting it with the dot prefix - what do you think?

@Yihao-G Yihao-G force-pushed the feature/feat_add_conversion_id_support branch from e0b456c to f3e6248 Compare January 30, 2026 00:57
@Yihao-G Graphite App
Copy link
Contributor Author

Yihao-G commented Jan 30, 2026

@andrewobrien Done! Added normalizeCookieDomainForSubdomains utility function in v11

@Yihao-G Yihao-G merged commit 8532b64 into master Jan 30, 2026
3 checks passed
@Yihao-G Yihao-G deleted the feature/feat_add_conversion_id_support branch January 30, 2026 01:02
github-actions bot pushed a commit that referenced this pull request Jan 30, 2026
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
c547ac0 
# [2.1.0](v2.0.1...v2.1.0) (2026-01-30)

### Features

* add conversion ID support ([#14](#14)) ([8532b64](8532b64))
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeapp macroscopeapp[bot] macroscopeapp[bot] left review comments

@andrewobrien andrewobrien andrewobrien approved these changes

@hui hui Awaiting requested review from hui

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yihao-G @andrewobrien