diff --git a/static/app/views/explore/metrics/useSaveAsMetricItems.tsx b/static/app/views/explore/metrics/useSaveAsMetricItems.tsx index 009a9af9c9a24f..fa0bfe65fd4bc2 100644 --- a/static/app/views/explore/metrics/useSaveAsMetricItems.tsx +++ b/static/app/views/explore/metrics/useSaveAsMetricItems.tsx @@ -111,15 +111,21 @@ export function useSaveAsMetricItems(_options: UseSaveAsMetricItemsOptions) { label: t('All Metrics'), textValue: t('All Metrics'), onAction: () => { - addToDashboard(metricQueries); + addToDashboard( + metricQueries.filter( + metricQuery => + !isVisualizeEquation(metricQuery.queryParams.visualizes[0]!) + ) + ); }, }, ] : []), ...metricQueries.map((metricQuery, index) => { + const visualize = metricQuery.queryParams.visualizes[0]!; return { key: `add-to-dashboard-${index}`, - label: `${metricQuery.label ?? getVisualizeLabel(index, isVisualizeEquation(metricQuery.queryParams.visualizes[0]!))}: ${ + label: `${metricQuery.label ?? getVisualizeLabel(index, isVisualizeEquation(visualize))}: ${ formatTraceMetricsFunction( metricQuery.queryParams.aggregateFields .filter(isVisualize) @@ -127,8 +133,15 @@ export function useSaveAsMetricItems(_options: UseSaveAsMetricItemsOptions) { ) as string }`, onAction: () => { + if (isVisualizeEquation(visualize)) { + return; + } addToDashboard(metricQuery); }, + disabled: isVisualizeEquation(visualize), + tooltip: isVisualizeEquation(visualize) + ? t('Equations cannot currently be added to a dashboard') + : undefined, }; }), ],