From 2296e6ce829372705fdd86c24fefa26d9b7bb294 Mon Sep 17 00:00:00 2001 From: Jay Goss Date: Tue, 14 Apr 2026 16:40:22 -0500 Subject: [PATCH] ref(onboarding): Rename SCM integration analytics view to onboarding_scm The SCM onboarding flow was using the generic 'onboarding' view value for integrations.installation_complete analytics. Rename to 'onboarding_scm' to avoid ambiguity with other surfaces that may use 'onboarding', ensuring clean experiment data. Refs VDY-81 --- static/app/utils/analytics/integrations/index.ts | 1 + static/app/utils/integrations/useAddIntegration.tsx | 1 + static/app/views/onboarding/components/scmProviderPills.tsx | 2 +- .../settings/organizationIntegrations/integrationContext.tsx | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/static/app/utils/analytics/integrations/index.ts b/static/app/utils/analytics/integrations/index.ts index 551df76ca7ee5b..e9efbbf0b61655 100644 --- a/static/app/utils/analytics/integrations/index.ts +++ b/static/app/utils/analytics/integrations/index.ts @@ -16,6 +16,7 @@ export type IntegrationView = { | 'stacktrace_issue_details' | 'integration_configuration_detail' | 'onboarding' + | 'onboarding_scm' | 'project_creation' | 'developer_settings' | 'new_integration_modal' diff --git a/static/app/utils/integrations/useAddIntegration.tsx b/static/app/utils/integrations/useAddIntegration.tsx index 02757ce3292568..3303edce04313f 100644 --- a/static/app/utils/integrations/useAddIntegration.tsx +++ b/static/app/utils/integrations/useAddIntegration.tsx @@ -24,6 +24,7 @@ export interface AddIntegrationParams { | 'integrations_directory_integration_detail' | 'integrations_directory' | 'onboarding' + | 'onboarding_scm' | 'project_creation' | 'seer_onboarding_github' | 'seer_onboarding_code_review' diff --git a/static/app/views/onboarding/components/scmProviderPills.tsx b/static/app/views/onboarding/components/scmProviderPills.tsx index cf9645c8fd6222..38bb6bce0e03f8 100644 --- a/static/app/views/onboarding/components/scmProviderPills.tsx +++ b/static/app/views/onboarding/components/scmProviderPills.tsx @@ -21,7 +21,7 @@ export function ScmProviderPills({providers, onInstall}: ScmProviderPillsProps) type: 'first_party', installStatus: 'Not Installed', analyticsParams: { - view: 'onboarding', + view: 'onboarding_scm', already_installed: false, }, }} diff --git a/static/app/views/settings/organizationIntegrations/integrationContext.tsx b/static/app/views/settings/organizationIntegrations/integrationContext.tsx index 60896698d45976..8c0776e443a462 100644 --- a/static/app/views/settings/organizationIntegrations/integrationContext.tsx +++ b/static/app/views/settings/organizationIntegrations/integrationContext.tsx @@ -11,6 +11,7 @@ type IntegrationContextProps = { | 'integrations_directory_integration_detail' | 'integrations_directory' | 'onboarding' + | 'onboarding_scm' | 'project_creation' | 'seer_onboarding_github' | 'seer_onboarding_code_review'