diff --git a/src/sentry/web/frontend/accept_organization_invite_redirect.py b/src/sentry/web/frontend/accept_organization_invite_redirect.py index cd92b6c6f51c47..605b3f7e82a941 100644 --- a/src/sentry/web/frontend/accept_organization_invite_redirect.py +++ b/src/sentry/web/frontend/accept_organization_invite_redirect.py @@ -1,6 +1,6 @@ from __future__ import annotations -from django.http import HttpRequest, HttpResponse, HttpResponseRedirect +from django.http import HttpRequest, HttpResponse, HttpResponseNotFound, HttpResponseRedirect from django.urls import reverse from sentry.api.endpoints.accept_organization_invite import get_invite_state @@ -29,11 +29,11 @@ def handle(self, request: HttpRequest, **kwargs) -> HttpResponse: request=request, ) if invite_context is None: - return self.handle_react(request, **kwargs) + return HttpResponseNotFound() helper = ApiInviteHelper(request=request, token=token, invite_context=invite_context) if not helper.valid_token: - return self.handle_react(request, **kwargs) + return HttpResponseNotFound() redirect_url = reverse( "sentry-organization-accept-invite", diff --git a/tests/sentry/web/frontend/test_accept_organization_invite_redirect.py b/tests/sentry/web/frontend/test_accept_organization_invite_redirect.py index 16945ab37c8712..261e6da36f481f 100644 --- a/tests/sentry/web/frontend/test_accept_organization_invite_redirect.py +++ b/tests/sentry/web/frontend/test_accept_organization_invite_redirect.py @@ -37,11 +37,9 @@ def test_invalid_token_does_not_leak_org_slug(self) -> None: reverse("sentry-accept-invite", args=[member.id, "invalidtoken"]) ) - assert response.status_code == 200 - self.assertTemplateUsed(response, "sentry/base-react.html") + assert response.status_code == 404 - def test_unresolved_legacy_invite_falls_back_to_react_page(self) -> None: + def test_unresolved_legacy_invite_returns_404(self) -> None: response = self.client.get(reverse("sentry-accept-invite", args=[123456, "invalidtoken"])) - assert response.status_code == 200 - self.assertTemplateUsed(response, "sentry/base-react.html") + assert response.status_code == 404