diff --git a/static/app/views/detectors/components/forms/cron/index.spec.tsx b/static/app/views/detectors/components/forms/cron/index.spec.tsx index a4cba9dc59dd2f..765cb6e95418e0 100644 --- a/static/app/views/detectors/components/forms/cron/index.spec.tsx +++ b/static/app/views/detectors/components/forms/cron/index.spec.tsx @@ -57,8 +57,7 @@ describe('NewCronDetectorForm', () => { renderForm(); // Form sections should be visible - expect(await screen.findByText(/Detect/)).toBeInTheDocument(); - expect(screen.getByText(/Issue Ownership/)).toBeInTheDocument(); + expect(await screen.findByTestId('form-sections')).toBeVisible(); // Create Monitor button should be present and enabled const createButton = screen.getByRole('button', {name: 'Create Monitor'}); @@ -78,8 +77,7 @@ describe('NewCronDetectorForm', () => { await screen.findByText('Step 2 of 2'); // Form sections should be hidden - expect(screen.queryByText(/Detect/)).not.toBeInTheDocument(); - expect(screen.queryByText(/Issue Ownership/)).not.toBeInTheDocument(); + expect(screen.getByTestId('form-sections')).not.toBeVisible(); // Create Monitor button should be present but disabled const createButton = screen.getByRole('button', {name: 'Create Monitor'}); diff --git a/static/app/views/detectors/components/forms/cron/index.tsx b/static/app/views/detectors/components/forms/cron/index.tsx index e3b7eca7dc386d..7487e05dc8d5d8 100644 --- a/static/app/views/detectors/components/forms/cron/index.tsx +++ b/static/app/views/detectors/components/forms/cron/index.tsx @@ -1,4 +1,3 @@ -import {Fragment} from 'react'; import {useTheme} from '@emotion/react'; import {Alert} from '@sentry/scraps/alert'; @@ -43,26 +42,26 @@ function CronDetectorForm({detector}: {detector?: CronDetector}) { const theme = useTheme(); const showingPlatformGuide = useIsShowingPlatformGuide(); - const formSections = ( - - {dataSource?.queryObj.isUpserting && ( - - {t( - 'This monitor is managed in code and updates automatically with each check-in. Changes made here may be overwritten!' - )} - - )} - - {FORM_SECTIONS.map((FormSection, index) => ( - - ))} - - ); - return ( {!detector && } - {!showingPlatformGuide && formSections} + + {dataSource?.queryObj.isUpserting && ( + + {t( + 'This monitor is managed in code and updates automatically with each check-in. Changes made here may be overwritten!' + )} + + )} + + {FORM_SECTIONS.map((FormSection, index) => ( + + ))} + ); }