From baae2c7afcf6c53847d654c2f3a1de3d91f693c4 Mon Sep 17 00:00:00 2001 From: Evan Purkhiser Date: Wed, 25 Mar 2026 09:38:27 -0400 Subject: [PATCH] ref(pipeline): Move `None` out of ApiPipelineSteps type Refs [VDY-32: Migrate integration setup pipelines to API-driven flows](https://linear.app/getsentry/issue/VDY-32/migrate-integration-setup-pipelines-to-api-driven-flows) --- src/sentry/integrations/base.py | 2 +- src/sentry/integrations/pipeline.py | 2 +- src/sentry/pipeline/base.py | 2 +- src/sentry/pipeline/provider.py | 2 +- src/sentry/pipeline/views/base.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sentry/integrations/base.py b/src/sentry/integrations/base.py index 1d27bb59e7d644..4098320f242e6f 100644 --- a/src/sentry/integrations/base.py +++ b/src/sentry/integrations/base.py @@ -312,7 +312,7 @@ def get_pipeline_views( """ raise NotImplementedError - def get_pipeline_api_steps(self) -> ApiPipelineSteps[IntegrationPipeline]: + def get_pipeline_api_steps(self) -> ApiPipelineSteps[IntegrationPipeline] | None: """ Return API step objects for this provider's pipeline, or None if API mode is not supported. Override to enable the pipeline API for this diff --git a/src/sentry/integrations/pipeline.py b/src/sentry/integrations/pipeline.py index 6a752ba3624fa6..7fd4cdc32b767c 100644 --- a/src/sentry/integrations/pipeline.py +++ b/src/sentry/integrations/pipeline.py @@ -172,7 +172,7 @@ def get_pipeline_views( ]: return self.provider.get_pipeline_views() - def get_pipeline_api_steps(self) -> ApiPipelineSteps[IntegrationPipeline]: + def get_pipeline_api_steps(self) -> ApiPipelineSteps[IntegrationPipeline] | None: return self.provider.get_pipeline_api_steps() def get_analytics_event(self) -> analytics.Event | None: diff --git a/src/sentry/pipeline/base.py b/src/sentry/pipeline/base.py index ef2ff667d89bcd..f3927caac554d8 100644 --- a/src/sentry/pipeline/base.py +++ b/src/sentry/pipeline/base.py @@ -260,7 +260,7 @@ def fetch_state(self, key: str | None = None) -> Any | None: return nested_pipeline.fetch_state(key) return self._fetch_state(key) - def get_pipeline_api_steps(self) -> ApiPipelineSteps[Self]: + def get_pipeline_api_steps(self) -> ApiPipelineSteps[Self] | None: """ Return API step objects for this pipeline, or None if API mode is not supported. Steps may be callables for late binding (resolved when the diff --git a/src/sentry/pipeline/provider.py b/src/sentry/pipeline/provider.py index 0a8644071c14d2..8fb23e76121715 100644 --- a/src/sentry/pipeline/provider.py +++ b/src/sentry/pipeline/provider.py @@ -36,7 +36,7 @@ def get_pipeline_views(self) -> Sequence[PipelineView[P] | Callable[[], Pipeline >>> return [OAuthInitView(), OAuthCallbackView()] """ - def get_pipeline_api_steps(self) -> ApiPipelineSteps[P]: + def get_pipeline_api_steps(self) -> ApiPipelineSteps[P] | None: """ Return API step objects for this provider's pipeline, or None if API mode is not supported. Override to enable the pipeline API. diff --git a/src/sentry/pipeline/views/base.py b/src/sentry/pipeline/views/base.py index 06e27e7075a558..4abfbfefff533e 100644 --- a/src/sentry/pipeline/views/base.py +++ b/src/sentry/pipeline/views/base.py @@ -58,7 +58,7 @@ def handle_post( type ApiPipelineStep[P] = ApiPipelineEndpoint[P] | Callable[[], ApiPipelineEndpoint[P]] -type ApiPipelineSteps[P] = Sequence[ApiPipelineStep[P]] | None +type ApiPipelineSteps[P] = Sequence[ApiPipelineStep[P]] def render_react_view(