Skip to content

feat(explore): Add logs export modal with row limit#112674

Draft
JoshuaKGoldberg wants to merge 13 commits intomasterfrom
joshuakgoldberg/feat/explore-logs-export-modal
Draft

feat(explore): Add logs export modal with row limit#112674
JoshuaKGoldberg wants to merge 13 commits intomasterfrom
joshuakgoldberg/feat/explore-logs-export-modal

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 10, 2026

Fixes LOGS-690.

Made with Cursor

Add DataExportWithModal (global modal + scraps form) beside the existing logs export control. Extend useDataExport to send an optional top-level limit to the data-export API.

Co-Authored-By: Cursor <noreply@cursor.com>
Made-with: Cursor
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 10, 2026
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Apr 14, 2026

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Status
sentry-frontend
sentry-frontend
0 0 0 0 204 ✅ Unchanged

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 14, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add back

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are unintentional, will revert...

});
}

type FetchMutationWithStatusResult<TData = unknown> = {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why Cursor shat this out and I have too much of a headache to deal with its crap right now. Will look tomorrow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant