Change the id list to be all the records and then use chunked to split

them into 10k groups to reduce the querying. update the tests to all be
1 test because of performance reasons in those tests

Author: saponifi3d

src/sentry/workflow_engine/migrations/0112_drop_redundant_error_detector_workflows.py

@@ -8,7 +8,7 @@
 
 from sentry.new_migrations.migrations import CheckedMigration
 from sentry.utils.iterators import chunked
-from sentry.utils.query import RangeQuerySetWrapper, bulk_delete_objects
+from sentry.utils.query import bulk_delete_objects
 
 logger = logging.getLogger(__name__)
 
@@ -30,19 +30,17 @@ def delete_redundant_error_detector_workflows(
     Detector = apps.get_model("workflow_engine", "Detector")
     DetectorWorkflow = apps.get_model("workflow_engine", "DetectorWorkflow")
 
-    error_detectors = Detector.objects.filter(type="error").only("id")
-
-    for chunk in chunked(RangeQuerySetWrapper(error_detectors, step=CHUNK_SIZE), CHUNK_SIZE):
-        chunk_ids = [d.id for d in chunk]
+    error_detector_ids = Detector.objects.filter(type="error").values_list("id", flat=True)
 
+    for chunk in chunked(error_detector_ids, CHUNK_SIZE):
         issue_stream_exists = DetectorWorkflow.objects.filter(
             workflow_id=OuterRef("workflow_id"),
             detector__type="issue_stream",
         )
 
         dws_to_delete = (
             DetectorWorkflow.objects.filter(
-                detector_id__in=chunk_ids,
+                detector_id__in=chunk,
             )
             .filter(Exists(issue_stream_exists))
             .values_list("id", flat=True)

tests/sentry/workflow_engine/migrations/test_0112_drop_redundant_error_detector_workflows.py

@@ -51,20 +51,21 @@ def setup_initial_state(self) -> None:
             detector=self.error_detector_p2, workflow=self.workflow_p2
         )
 
-    def test_deletes_error_workflow_with_matching_issue_stream(self) -> None:
+    def test_connections_are_correct_after_migration(self) -> None:
+        # test deletes error workflow with matching issue stream
         assert not DetectorWorkflow.objects.filter(id=self.dw_error_should_delete.id).exists()
 
-    def test_preserves_issue_stream_workflow_when_error_deleted(self) -> None:
+        # test preserves issue stream workflow when error deleted
         assert DetectorWorkflow.objects.filter(id=self.dw_issue_stream_keep.id).exists()
 
-    def test_preserves_error_workflow_without_matching_issue_stream(self) -> None:
+        # test preserves error workflow without matching issue stream
         assert DetectorWorkflow.objects.filter(id=self.dw_error_no_match.id).exists()
 
-    def test_preserves_issue_stream_only_workflow(self) -> None:
+        # test preserves issue stream only workflow
         assert DetectorWorkflow.objects.filter(id=self.dw_issue_stream_only.id).exists()
 
-    def test_preserves_cross_project_error_workflow_without_issue_stream(self) -> None:
+        # test preserves cross project error workflow without issue stream
         assert DetectorWorkflow.objects.filter(id=self.dw_error_project2.id).exists()
 
-    def test_total_count_after_migration(self) -> None:
+        # test total count after migration
         assert DetectorWorkflow.objects.count() == 4