Skip to content

Commit f86a1c3

Browse files
grichacodex
andcommitted
test(viewer-context): Fix DRF request typing in endpoint tests
Keep the endpoint viewer-context regression tests type-safe by separating the raw WSGI request from the DRF request wrapper used for convert_args. This matches the actual request shapes under test and fixes the backend typing job without changing runtime behavior. Co-Authored-By: Codex <codex@openai.com>
1 parent aba9936 commit f86a1c3

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

tests/sentry/api/bases/test_project.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ def has_object_perm(
4141
class ProjectEndpointViewerContextTest(TestCase):
4242
def test_convert_args_enriches_viewer_context_with_organization(self) -> None:
4343
endpoint = ProjectEndpoint()
44-
request = RequestFactory().get("/")
45-
request.session = SessionBase()
46-
request.user = self.user
47-
request.auth = None
48-
request.access = from_request(drf_request_from_request(request), self.organization)
49-
request = drf_request_from_request(request)
44+
raw_request = RequestFactory().get("/")
45+
raw_request.session = SessionBase()
46+
raw_request.user = self.user
47+
raw_request.auth = None
48+
raw_request.access = from_request(drf_request_from_request(raw_request), self.organization)
49+
request = drf_request_from_request(raw_request)
5050
request._request.organization = None
5151

5252
with viewer_context_scope(ViewerContext(user_id=self.user.id)):

tests/sentry/api/bases/test_team.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ class TeamEndpointViewerContextTest(TeamPermissionBase):
4141
def test_convert_args_enriches_viewer_context_with_organization(self) -> None:
4242
endpoint = TeamEndpoint()
4343
self.create_member(user=self.user, organization=self.org, role="member", teams=[self.team])
44-
request = RequestFactory().get("/")
45-
request.session = SessionBase()
46-
request.user = self.user
47-
request.auth = None
48-
request.access = from_request(drf_request_from_request(request), self.org)
49-
request = drf_request_from_request(request)
44+
raw_request = RequestFactory().get("/")
45+
raw_request.session = SessionBase()
46+
raw_request.user = self.user
47+
raw_request.auth = None
48+
raw_request.access = from_request(drf_request_from_request(raw_request), self.org)
49+
request = drf_request_from_request(raw_request)
5050
request._request.organization = None
5151

5252
with viewer_context_scope(ViewerContext(user_id=self.user.id)):

0 commit comments

Comments
 (0)