Skip to content

Commit f7ff2ae

Browse files
committed
Fix up small bug
1 parent 77c3d5c commit f7ff2ae

File tree

1 file changed

+6
-5
lines changed
  • static/app/views/explore/metrics/metricToolbar

1 file changed

+6
-5
lines changed

static/app/views/explore/metrics/metricToolbar/filter.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,24 +67,25 @@ export function Filter({traceMetric, skipTraceMetricFilter}: FilterProps) {
6767
);
6868

6969
const traceMetricFilter = createTraceMetricFilter(traceMetric);
70+
const attributeQuery = skipTraceMetricFilter ? undefined : traceMetricFilter;
7071

7172
const {attributes: numberTags} = useTraceItemAttributeKeys({
7273
traceItemType: TraceItemDataset.TRACEMETRICS,
7374
type: 'number',
7475
enabled: skipTraceMetricFilter || Boolean(traceMetricFilter),
75-
query: skipTraceMetricFilter ? undefined : traceMetricFilter,
76+
query: attributeQuery,
7677
});
7778
const {attributes: stringTags} = useTraceItemAttributeKeys({
7879
traceItemType: TraceItemDataset.TRACEMETRICS,
7980
type: 'string',
8081
enabled: skipTraceMetricFilter || Boolean(traceMetricFilter),
81-
query: skipTraceMetricFilter ? undefined : traceMetricFilter,
82+
query: attributeQuery,
8283
});
8384
const {attributes: booleanTags} = useTraceItemAttributeKeys({
8485
traceItemType: TraceItemDataset.TRACEMETRICS,
8586
type: 'boolean',
8687
enabled: skipTraceMetricFilter || Boolean(traceMetricFilter),
87-
query: skipTraceMetricFilter ? undefined : traceMetricFilter,
88+
query: attributeQuery,
8889
});
8990

9091
const visibleNumberTags = useMemo(() => {
@@ -155,7 +156,7 @@ export function Filter({traceMetric, skipTraceMetricFilter}: FilterProps) {
155156
onSearch: setQuery,
156157
searchSource: 'tracemetrics',
157158
namespace: traceMetric.name,
158-
attributeQuery: traceMetricFilter,
159+
attributeQuery,
159160
hiddenAttributeKeys: HiddenTraceMetricSearchFields,
160161

161162
// Disable the recent searches when not using a trace metric filter because
@@ -169,7 +170,7 @@ export function Filter({traceMetric, skipTraceMetricFilter}: FilterProps) {
169170
visibleNumberTags,
170171
visibleStringTags,
171172
traceMetric.name,
172-
traceMetricFilter,
173+
attributeQuery,
173174
skipTraceMetricFilter,
174175
]);
175176

0 commit comments

Comments
 (0)