test(dashboards): Move revision unit tests to model layer

Pruning and field-correctness tests for DashboardRevision.create_for_dashboard
now live in test_dashboard.py, tested directly without going through HTTP.

The endpoint tests are trimmed to only verify the endpoint wires up to the
model correctly — they no longer re-test the model's own behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: skaasten

tests/sentry/dashboards/endpoints/test_organization_dashboard_details.py

@@ -4014,21 +4014,12 @@ def test_text_widget_errors_provided_queries(self) -> None:
             assert response.data["widgets"][1]["queries"][0] == "Text widgets don't have queries"
 
     def test_put_creates_dashboard_revision_when_feature_enabled(self) -> None:
-        original_title = self.dashboard.title
         with self.feature("organizations:dashboards-revisions"):
             response = self.do_request(
                 "put", self.url(self.dashboard.id), data={"title": "Updated Title"}
             )
         assert response.status_code == 200, response.data
-
-        revisions = DashboardRevision.objects.filter(dashboard=self.dashboard)
-        assert revisions.count() == 1
-        revision = revisions.first()
-        assert revision is not None
-        assert revision.title == original_title
-        assert revision.snapshot["title"] == original_title
-        assert revision.snapshot_schema_version == 1
-        assert revision.created_by_id == self.user.id
+        assert DashboardRevision.objects.filter(dashboard=self.dashboard).count() == 1
 
     def test_put_does_not_create_revision_when_feature_disabled(self) -> None:
         response = self.do_request(
@@ -4049,28 +4040,6 @@ def test_put_snapshot_contains_pre_save_state(self) -> None:
         self.dashboard.refresh_from_db()
         assert self.dashboard.title == "New Title"
 
-    def test_put_deletes_revisions_beyond_retention_limit(self) -> None:
-        # Create 10 existing revisions
-        for i in range(10):
-            DashboardRevision.objects.create(
-                dashboard=self.dashboard,
-                created_by_id=self.user.id,
-                title=f"Revision {i}",
-                snapshot={},
-                snapshot_schema_version=1,
-            )
-
-        assert DashboardRevision.objects.filter(dashboard=self.dashboard).count() == 10
-
-        with self.feature("organizations:dashboards-revisions"):
-            response = self.do_request(
-                "put", self.url(self.dashboard.id), data={"title": "Updated Title"}
-            )
-        assert response.status_code == 200, response.data
-
-        # After creating the 11th revision, the oldest should be deleted to maintain 10
-        assert DashboardRevision.objects.filter(dashboard=self.dashboard).count() == 10
-
     def test_put_snapshot_includes_widgets_and_queries(self) -> None:
         with self.feature("organizations:dashboards-revisions"):
             self.do_request("put", self.url(self.dashboard.id), data={"title": "New Title"})

tests/sentry/models/test_dashboard.py

@@ -1,4 +1,4 @@
-from sentry.models.dashboard import Dashboard, DashboardFavoriteUser
+from sentry.models.dashboard import Dashboard, DashboardFavoriteUser, DashboardRevision
 from sentry.models.organization import Organization
 from sentry.testutils.cases import TestCase
 from sentry.users.models.user import User
@@ -187,3 +187,57 @@ def test_deletes_and_increments_existing_positions(self) -> None:
         assert unfavorited.position is None
         assert dashboard is not None
         assert dashboard.position == 0
+
+
+class DashboardRevisionTest(TestCase):
+    def setUp(self) -> None:
+        super().setUp()
+        self.dashboard = self.create_dashboard(title="My Dashboard", organization=self.organization)
+
+    def test_create_for_dashboard_stores_correct_fields(self) -> None:
+        snapshot = {"title": "My Dashboard", "widgets": []}
+        revision = DashboardRevision.create_for_dashboard(self.dashboard, self.user, snapshot)
+
+        assert revision.dashboard == self.dashboard
+        assert revision.title == self.dashboard.title
+        assert revision.snapshot == snapshot
+        assert revision.snapshot_schema_version == DashboardRevision.SNAPSHOT_SCHEMA_VERSION
+        assert revision.created_by_id == self.user.id
+
+    def test_create_for_dashboard_prunes_beyond_retention_limit(self) -> None:
+        for i in range(DashboardRevision.RETENTION_LIMIT):
+            DashboardRevision.objects.create(
+                dashboard=self.dashboard,
+                created_by_id=self.user.id,
+                title=f"Revision {i}",
+                snapshot={},
+                snapshot_schema_version=DashboardRevision.SNAPSHOT_SCHEMA_VERSION,
+            )
+
+        DashboardRevision.create_for_dashboard(self.dashboard, self.user, {})
+
+        assert (
+            DashboardRevision.objects.filter(dashboard=self.dashboard).count()
+            == DashboardRevision.RETENTION_LIMIT
+        )
+
+    def test_create_for_dashboard_retains_newest_revisions(self) -> None:
+        titles = [f"Revision {i}" for i in range(DashboardRevision.RETENTION_LIMIT)]
+        for title in titles:
+            DashboardRevision.objects.create(
+                dashboard=self.dashboard,
+                created_by_id=self.user.id,
+                title=title,
+                snapshot={},
+                snapshot_schema_version=DashboardRevision.SNAPSHOT_SCHEMA_VERSION,
+            )
+
+        new_revision = DashboardRevision.create_for_dashboard(self.dashboard, self.user, {})
+
+        surviving_ids = set(
+            DashboardRevision.objects.filter(dashboard=self.dashboard).values_list("id", flat=True)
+        )
+        # The oldest revision was pruned; the new one and the 9 most recent survive
+        oldest = DashboardRevision.objects.filter(title="Revision 0").first()
+        assert oldest is None
+        assert new_revision.id in surviving_ids