fix(autofix): Fall back to code mappings when preference has empty repos

read_preference_from_sentry_db now always returns a SeerProjectPreference
instead of None, removing the has_configured_options gate that could
incorrectly treat mechanically-written default options as "configured".

_resolve_project_preference now checks preference.repositories instead
of just truthiness — when repos are empty it falls through to the code
mapping fallback while preserving the user's existing stopping point
and handoff settings.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: srest2021

src/sentry/seer/autofix/autofix.py

@@ -643,9 +643,11 @@ def _resolve_project_preference(
     """
     Resolve the Seer project preference for a project before triggering autofix.
 
-    If an existing preference is found in Seer, returns it.
-    If not, creates one from fallback_repos.
+    If an existing preference with repositories is found, returns it.
+    Otherwise, creates one using fallback repos and preserves any existing
+    stopping point / handoff settings.
     """
+    preference: SeerProjectPreference | None = None
     if features.has("organizations:seer-project-settings-read-from-sentry", organization):
         preference = read_preference_from_sentry_db(project)
     else:
@@ -658,16 +660,24 @@ def _resolve_project_preference(
             )
             return None
 
-    if preference:
+    if preference and preference.repositories:
         return preference
 
-    default_stopping_point, default_handoff = get_org_default_seer_automation_handoff(organization)
+    if preference:
+        # Preference exists but has no repos —
+        # keep the user's existing stopping point and handoff settings.
+        stopping_point = preference.automated_run_stopping_point
+        handoff = preference.automation_handoff
+    else:
+        # No preference at all — use org defaults.
+        stopping_point, handoff = get_org_default_seer_automation_handoff(organization)
+
     preference = SeerProjectPreference(
         organization_id=organization.id,
         project_id=project.id,
         repositories=fallback_repos,
-        automated_run_stopping_point=default_stopping_point,
-        automation_handoff=default_handoff,
+        automated_run_stopping_point=stopping_point,
+        automation_handoff=handoff,
     )
 
     try:
@@ -684,7 +694,7 @@ def _resolve_project_preference(
             write_preference_to_sentry_db(project, preference)
         except Exception:
             logger.exception(
-                "seer.write_preferences.resolve_project_preference.sentry_db_write_failed",
+                "seer.resolve_project_preference.write_failed",
                 extra={"project_id": project.id, "organization_id": organization.id},
                 exc_info=True,
             )

src/sentry/seer/autofix/issue_summary.py

@@ -506,8 +506,7 @@ def get_automation_stopping_point(group: Group) -> AutofixStoppingPoint:
     fixability_stopping_point = _get_stopping_point_from_fixability(fixability_score)
 
     if features.has("organizations:seer-project-settings-read-from-sentry", group.organization):
-        preference = read_preference_from_sentry_db(group.project)
-        user_preference = preference.automated_run_stopping_point if preference else None
+        user_preference = read_preference_from_sentry_db(group.project).automated_run_stopping_point
     else:
         user_preference = _fetch_user_preference(group.project.id)
 

src/sentry/seer/autofix/utils.py

@@ -734,7 +734,7 @@ def _build_automation_handoff(
     )
 
 
-def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference | None:
+def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference:
     """Read a single project's Seer preferences from Sentry DB.
 
     For now, should only be used under feature flag `organizations:seer-project-settings-read-from-sentry`."""
@@ -749,12 +749,6 @@ def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference |
         if (repo_def := build_repo_definition_from_project_repo(project_repo)) is not None
     ]
 
-    has_configured_options = any(
-        ProjectOption.objects.isset(project, key) for key in SEER_PROJECT_PREFERENCE_OPTION_KEYS
-    )
-    if not repo_definitions and not has_configured_options:
-        return None
-
     return SeerProjectPreference(
         organization_id=project.organization_id,
         project_id=project.id,
@@ -767,7 +761,7 @@ def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference |
 
 def bulk_read_preferences_from_sentry_db(
     organization_id: int, project_ids: list[int]
-) -> dict[int, SeerProjectPreference | None]:
+) -> dict[int, SeerProjectPreference]:
     """Bulk read Seer preferences from Sentry DB.
 
     For now, should only be used under feature flag `organizations:seer-project-settings-read-from-sentry`."""
@@ -793,15 +787,8 @@ def bulk_read_preferences_from_sentry_db(
         for key in SEER_PROJECT_PREFERENCE_OPTION_KEYS
     }
 
-    result: dict[int, SeerProjectPreference | None] = {}
+    result: dict[int, SeerProjectPreference] = {}
     for project in projects:
-        has_configured_options = any(
-            project_options[key][project.id] is not None
-            for key in SEER_PROJECT_PREFERENCE_OPTION_KEYS
-        )
-        if project.id not in repo_definitions_by_project and not has_configured_options:
-            result[project.id] = None
-            continue
 
         def _get_project_option(key: str) -> Any:
             value = project_options[key][project.id]
@@ -831,7 +818,7 @@ def bulk_read_preferences(
     Always returns ``dict[int, SeerProjectPreference | None]`` regardless of the
     underlying read path (Sentry DB or Seer API)."""
     if features.has("organizations:seer-project-settings-read-from-sentry", organization):
-        return bulk_read_preferences_from_sentry_db(organization.id, project_ids)
+        return bulk_read_preferences_from_sentry_db(organization.id, project_ids)  # type: ignore[return-value]
 
     raw = bulk_get_project_preferences(organization.id, project_ids)
     tuning_by_id = ProjectOption.objects.get_value_bulk_id(
@@ -887,8 +874,7 @@ def has_project_connected_repos(
 
     has_repos = False
     if features.has("organizations:seer-project-settings-read-from-sentry", organization):
-        preference = read_preference_from_sentry_db(project)
-        has_repos = bool(preference and preference.repositories)
+        has_repos = bool(read_preference_from_sentry_db(project).repositories)
     else:
         try:
             preference = get_project_seer_preferences(project.id).preference