add backward compat -- delegate to issue-details if multicell called on old url

Author: lynnagara

src/sentry/middleware/integrations/parsers/jira.py

@@ -67,12 +67,15 @@ def get_response(self) -> HttpResponseBase:
         if len(cells) == 0:
             return self.get_default_missing_integration_response()
 
-        if self.view_class in self.immediate_response_cell_classes and len(cells) == 1:
-            try:
-                return self.get_response_from_cell_silo(cell=cells[0])
-            except ApiError as err:
-                sentry_sdk.capture_exception(err)
-                return self.get_response_from_control_silo()
+        if self.view_class in self.immediate_response_cell_classes:
+            if len(cells) == 1:
+                try:
+                    return self.get_response_from_cell_silo(cell=cells[0])
+                except ApiError as err:
+                    sentry_sdk.capture_exception(err)
+                    return self.get_response_from_control_silo()
+            # TODO(cells): Remove once all installs have migrated to JiraSentryIssueDetailsControlView.
+            return JiraSentryIssueDetailsControlView.as_view()(self.request, **self.match.kwargs)
 
         if self.view_class in self.outbox_response_cell_classes:
             return self.get_response_from_webhookpayload(

tests/sentry/middleware/integrations/parsers/test_jira.py

@@ -185,26 +185,20 @@ def test_get_response_invalid_path(self) -> None:
 
     @override_cells(region_config)
     @override_settings(SILO_MODE=SiloMode.CONTROL)
-    @responses.activate
     def test_get_response_multiple_regions(self) -> None:
-        responses.add(
-            responses.POST,
-            eu_locality.to_url("/extensions/jira/issue/LR-123/"),
-            body="region response",
-            status=200,
-        )
-        request = self.factory.post(path=f"{self.path_base}/issue/LR-123/")
+        # Use GET — the view only handles GET, and Jira sends GET for issue hooks.
+        request = self.factory.get(path=f"{self.path_base}/issue/LR-123/")
         parser = JiraRequestParser(request, self.get_response)
 
-        # Add a second organization. Jira only supports single regions.
         other_org = self.create_organization(owner=self.user, region="eu")
         integration = self.get_integration()
         integration.add_organization(other_org.id)
 
-        with patch.object(parser, "get_integration_from_request") as method:
-            method.return_value = integration
-            # Multi-cell installs fall back to control silo rather than raising
+        with patch.object(parser, "get_integration_from_request") as mock_integration:
+            mock_integration.return_value = integration
             response = parser.get_response()
-            assert response.status_code == 200
 
+        # Must not 404 — multi-cell falls back to JiraSentryIssueDetailsControlView, not
+        # get_response_from_control_silo() which would 404 via the @cell_silo_view restriction.
+        assert response.status_code == 200
         assert_no_webhook_payloads()