ref(night-shift): Use seer-project-settings helpers for project eligibility

Replace direct SeerProjectRepository queries in _get_eligible_projects
with bulk_read_preferences_from_sentry_db / bulk_get_project_preferences
behind the seer-project-settings-read-from-sentry feature flag, matching
the pattern used in context_engine_index and autofix.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Agent transcript: https://claudescope.sentry.dev/share/TusCoPLrgCYHLxdSUeDTGIDPYU1f6BITAaO7rK6QDl0

Author: chromy

src/sentry/projectoptions/defaults.py

@@ -196,14 +196,19 @@
 register(key="sentry:seer_automation_handoff_integration_id", default=None)
 register(key="sentry:seer_automation_handoff_auto_create_pr", default=False)
 
-SEER_PROJECT_PREFERENCE_OPTION_KEYS = [
+DEFAULTING_SEER_PROJECT_PREFERENCE_OPTION_KEYS = [
     "sentry:seer_automated_run_stopping_point",
     "sentry:seer_automation_handoff_point",
     "sentry:seer_automation_handoff_target",
     "sentry:seer_automation_handoff_integration_id",
     "sentry:seer_automation_handoff_auto_create_pr",
 ]
 
+SEER_PROJECT_PREFERENCE_OPTION_KEYS = [
+    *DEFAULTING_SEER_PROJECT_PREFERENCE_OPTION_KEYS,
+    "sentry:autofix_automation_tuning",
+]
+
 # Boolean to enable/disable preprod size analysis for this project.
 register(key="sentry:preprod_size_enabled_by_customer", default=True)
 

src/sentry/seer/autofix/utils.py

@@ -32,7 +32,10 @@
 from sentry.models.project import Project
 from sentry.models.repository import Repository
 from sentry.net.http import connection_from_url
-from sentry.projectoptions.defaults import SEER_PROJECT_PREFERENCE_OPTION_KEYS
+from sentry.projectoptions.defaults import (
+    DEFAULTING_SEER_PROJECT_PREFERENCE_OPTION_KEYS,
+    SEER_PROJECT_PREFERENCE_OPTION_KEYS,
+)
 from sentry.seer.autofix.constants import AutofixAutomationTuningSettings, AutofixStatus
 from sentry.seer.constants import SEER_SUPPORTED_SCM_PROVIDERS
 from sentry.seer.models import (
@@ -747,7 +750,8 @@ def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference |
     ]
 
     has_configured_options = any(
-        ProjectOption.objects.isset(project, key) for key in SEER_PROJECT_PREFERENCE_OPTION_KEYS
+        ProjectOption.objects.isset(project, key)
+        for key in DEFAULTING_SEER_PROJECT_PREFERENCE_OPTION_KEYS
     )
     if not repo_definitions and not has_configured_options:
         return None
@@ -758,6 +762,7 @@ def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference |
         repositories=repo_definitions,
         automated_run_stopping_point=project.get_option("sentry:seer_automated_run_stopping_point"),
         automation_handoff=_build_automation_handoff(project.get_option),
+        autofix_automation_tuning=project.get_option("sentry:autofix_automation_tuning"),
     )
 
 
@@ -793,7 +798,7 @@ def bulk_read_preferences_from_sentry_db(
     for project in projects:
         has_configured_options = any(
             project_options[key][project.id] is not None
-            for key in SEER_PROJECT_PREFERENCE_OPTION_KEYS
+            for key in DEFAULTING_SEER_PROJECT_PREFERENCE_OPTION_KEYS
         )
         if project.id not in repo_definitions_by_project and not has_configured_options:
             result[project.id] = None
@@ -813,11 +818,39 @@ def _get_project_option(key: str) -> Any:
                 "sentry:seer_automated_run_stopping_point"
             ),
             automation_handoff=_build_automation_handoff(_get_project_option),
+            autofix_automation_tuning=_get_project_option("sentry:autofix_automation_tuning"),
         )
 
     return result
 
 
+def bulk_read_preferences(
+    organization: Organization, project_ids: list[int]
+) -> dict[int, SeerProjectPreference | None]:
+    """Read Seer project preferences in bulk, using the correct source based on feature flag.
+
+    Always returns ``dict[int, SeerProjectPreference | None]`` regardless of the
+    underlying read path (Sentry DB or Seer API)."""
+    if features.has("organizations:seer-project-settings-read-from-sentry", organization):
+        return bulk_read_preferences_from_sentry_db(organization.id, project_ids)
+
+    raw = bulk_get_project_preferences(organization.id, project_ids)
+    result: dict[int, SeerProjectPreference | None] = {}
+    for pid, data in raw.items():
+        if data is None:
+            result[int(pid)] = None
+            continue
+        try:
+            result[int(pid)] = SeerProjectPreference.validate(data)
+        except pydantic.ValidationError:
+            logger.exception(
+                "seer.bulk_read_preferences.validation_error",
+                extra={"project_id": pid, "organization_id": organization.id},
+            )
+            result[int(pid)] = None
+    return result
+
+
 def set_project_seer_preference(preference: SeerProjectPreference) -> None:
     """Set Seer project preference for a single project via Seer API."""
     response = make_set_project_preference_request(

src/sentry/seer/models/seer_api_models.py

@@ -5,6 +5,8 @@
 
 from pydantic import BaseModel, Field
 
+from sentry.seer.autofix.constants import AutofixAutomationTuningSettings
+
 
 class BranchOverride(BaseModel):
     tag_name: str = Field(description="The tag key to match against")
@@ -96,6 +98,7 @@ class SeerProjectPreference(BaseModel):
     repositories: list[SeerRepoDefinition]
     automated_run_stopping_point: str | None = None
     automation_handoff: SeerAutomationHandoffConfiguration | None = None
+    autofix_automation_tuning: AutofixAutomationTuningSettings | None = None
 
 
 class SeerRawPreferenceResponse(BaseModel):

src/sentry/tasks/seer/night_shift/cron.py

@@ -11,8 +11,8 @@
 from sentry.models.organization import Organization, OrganizationStatus
 from sentry.models.project import Project
 from sentry.seer.autofix.constants import AutofixAutomationTuningSettings
+from sentry.seer.autofix.utils import bulk_read_preferences
 from sentry.seer.models.night_shift import SeerNightShiftRun, SeerNightShiftRunIssue
-from sentry.seer.models.project_repository import SeerProjectRepository
 from sentry.tasks.base import instrumented_task
 from sentry.tasks.seer.night_shift.agentic_triage import agentic_triage_strategy
 from sentry.taskworker.namespaces import seer_tasks
@@ -173,18 +173,19 @@ def _get_eligible_orgs_from_batch(
 
 def _get_eligible_projects(organization: Organization) -> list[Project]:
     """Return active projects that have automation enabled and connected repos."""
-    projects_with_repos = set(
-        SeerProjectRepository.objects.filter(
-            project__organization=organization,
-            project__status=ObjectStatus.ACTIVE,
-        ).values_list("project_id", flat=True)
-    )
-    if not projects_with_repos:
+    projects = list(Project.objects.filter(organization=organization, status=ObjectStatus.ACTIVE))
+    if not projects:
         return []
 
-    projects = Project.objects.filter(id__in=projects_with_repos)
+    project_ids = [p.id for p in projects]
+    project_map = {p.id: p for p in projects}
+    preferences = bulk_read_preferences(organization, project_ids)
+
     return [
-        p
-        for p in projects
-        if p.get_option("sentry:autofix_automation_tuning") != AutofixAutomationTuningSettings.OFF
+        project_map[pid]
+        for pid, pref in preferences.items()
+        if pref is not None
+        and pid in project_map
+        and pref.repositories
+        and pref.autofix_automation_tuning != AutofixAutomationTuningSettings.OFF
     ]

tests/sentry/seer/autofix/test_autofix_utils.py

@@ -5,7 +5,7 @@
 import pytest
 
 from sentry.constants import SEER_AUTOMATED_RUN_STOPPING_POINT_DEFAULT, DataCategory
-from sentry.seer.autofix.constants import AutofixStatus
+from sentry.seer.autofix.constants import AutofixAutomationTuningSettings, AutofixStatus
 from sentry.seer.autofix.trigger import is_issue_eligible_for_seer_automation
 from sentry.seer.autofix.utils import (
     AutofixState,
@@ -1311,6 +1311,35 @@ def test_project_with_repos_only(self):
         assert result.automated_run_stopping_point == "code_changes"
         assert result.automation_handoff is None
 
+    def test_autofix_automation_tuning_default(self):
+        SeerProjectRepository.objects.create(
+            project=self.project, repository=self.repo, branch_name="main"
+        )
+
+        result = read_preference_from_sentry_db(self.project)
+        assert result is not None
+        assert result.autofix_automation_tuning == AutofixAutomationTuningSettings.OFF
+
+    def test_autofix_automation_tuning_explicit(self):
+        SeerProjectRepository.objects.create(
+            project=self.project, repository=self.repo, branch_name="main"
+        )
+        self.project.update_option(
+            "sentry:autofix_automation_tuning", AutofixAutomationTuningSettings.MEDIUM
+        )
+
+        result = read_preference_from_sentry_db(self.project)
+        assert result is not None
+        assert result.autofix_automation_tuning == AutofixAutomationTuningSettings.MEDIUM
+
+    def test_autofix_automation_tuning_alone_does_not_create_preference(self):
+        self.project.update_option(
+            "sentry:autofix_automation_tuning", AutofixAutomationTuningSettings.HIGH
+        )
+
+        result = read_preference_from_sentry_db(self.project)
+        assert result is None
+
     def test_project_with_stopping_point_only(self):
         self.project.update_option("sentry:seer_automated_run_stopping_point", "open_pr")
 
@@ -1479,6 +1508,35 @@ def test_bulk_returns_correct_preferences(self):
         assert pref2.automation_handoff.integration_id == 99
         assert pref2.automation_handoff.auto_create_pr is False
 
+    def test_autofix_automation_tuning_populated(self):
+        SeerProjectRepository.objects.create(
+            project=self.project1, repository=self.repo, branch_name="main"
+        )
+        self.project1.update_option(
+            "sentry:autofix_automation_tuning", AutofixAutomationTuningSettings.HIGH
+        )
+
+        result = bulk_read_preferences_from_sentry_db(
+            self.organization.id, [self.project1.id, self.project2.id]
+        )
+
+        pref1 = result[self.project1.id]
+        assert pref1 is not None
+        assert pref1.autofix_automation_tuning == AutofixAutomationTuningSettings.HIGH
+
+        assert result[self.project2.id] is None
+
+    def test_autofix_automation_tuning_defaults_to_off(self):
+        SeerProjectRepository.objects.create(
+            project=self.project1, repository=self.repo, branch_name="main"
+        )
+
+        result = bulk_read_preferences_from_sentry_db(self.organization.id, [self.project1.id])
+
+        pref = result[self.project1.id]
+        assert pref is not None
+        assert pref.autofix_automation_tuning == AutofixAutomationTuningSettings.OFF
+
     def test_wrong_organization_excluded(self):
         other_org = self.create_organization()
         SeerProjectRepository.objects.create(

tests/sentry/tasks/seer/test_night_shift.py

@@ -92,19 +92,20 @@ def test_filters_by_automation_and_repos(self) -> None:
         eligible.update_option(
             "sentry:autofix_automation_tuning", AutofixAutomationTuningSettings.MEDIUM
         )
-        repo = self.create_repo(project=eligible, provider="github")
+        repo = self.create_repo(project=eligible, provider="github", name="owner/eligible-repo")
         SeerProjectRepository.objects.create(project=eligible, repository=repo)
 
         # Automation off (even with repo)
         off = self.create_project(organization=org)
         off.update_option("sentry:autofix_automation_tuning", AutofixAutomationTuningSettings.OFF)
-        repo2 = self.create_repo(project=off, provider="github")
+        repo2 = self.create_repo(project=off, provider="github", name="owner/off-repo")
         SeerProjectRepository.objects.create(project=off, repository=repo2)
 
         # No connected repo
         self.create_project(organization=org)
 
-        assert _get_eligible_projects(org) == [eligible]
+        with self.feature("organizations:seer-project-settings-read-from-sentry"):
+            assert _get_eligible_projects(org) == [eligible]
 
 
 @django_db_all
@@ -115,7 +116,7 @@ def _make_eligible(self, project):
         project.update_option(
             "sentry:autofix_automation_tuning", AutofixAutomationTuningSettings.MEDIUM
         )
-        repo = self.create_repo(project=project, provider="github")
+        repo = self.create_repo(project=project, provider="github", name=f"owner/{project.slug}")
         SeerProjectRepository.objects.create(project=project, repository=repo)
 
     def _store_event_and_update_group(self, project, fingerprint, **group_attrs):
@@ -139,7 +140,10 @@ def test_no_eligible_projects(self) -> None:
         org = self.create_organization()
         self.create_project(organization=org)
 
-        with patch("sentry.tasks.seer.night_shift.cron.logger") as mock_logger:
+        with (
+            self.feature("organizations:seer-project-settings-read-from-sentry"),
+            patch("sentry.tasks.seer.night_shift.cron.logger") as mock_logger,
+        ):
             run_night_shift_for_org(org.id)
             mock_logger.info.assert_called_once()
             assert mock_logger.info.call_args.args[0] == "night_shift.no_eligible_projects"
@@ -166,6 +170,7 @@ def test_selects_candidates_and_skips_triggered(self) -> None:
         )
 
         with (
+            self.feature("organizations:seer-project-settings-read-from-sentry"),
             patch(
                 "sentry.tasks.seer.night_shift.agentic_triage.make_llm_generate_request",
                 return_value=_mock_llm_response([high_fix.id, low_fix.id]),
@@ -204,6 +209,7 @@ def test_global_ranking_across_projects(self) -> None:
         )
 
         with (
+            self.feature("organizations:seer-project-settings-read-from-sentry"),
             patch(
                 "sentry.tasks.seer.night_shift.agentic_triage.make_llm_generate_request",
                 return_value=_mock_llm_response([high_group.id, low_group.id]),
@@ -225,9 +231,12 @@ def test_triage_error_records_error_message(self) -> None:
             project, "fixable", seer_fixability_score=0.9, times_seen=5
         )
 
-        with patch(
-            "sentry.tasks.seer.night_shift.cron.agentic_triage_strategy",
-            side_effect=RuntimeError("boom"),
+        with (
+            self.feature("organizations:seer-project-settings-read-from-sentry"),
+            patch(
+                "sentry.tasks.seer.night_shift.cron.agentic_triage_strategy",
+                side_effect=RuntimeError("boom"),
+            ),
         ):
             run_night_shift_for_org(org.id)
 
@@ -244,9 +253,12 @@ def test_empty_candidates_creates_run_with_no_issues(self) -> None:
             project, "fixable", seer_fixability_score=0.9, times_seen=5
         )
 
-        with patch(
-            "sentry.tasks.seer.night_shift.cron.agentic_triage_strategy",
-            return_value=[],
+        with (
+            self.feature("organizations:seer-project-settings-read-from-sentry"),
+            patch(
+                "sentry.tasks.seer.night_shift.cron.agentic_triage_strategy",
+                return_value=[],
+            ),
         ):
             run_night_shift_for_org(org.id)