File tree Expand file tree Collapse file tree 5 files changed +16
-29
lines changed
static/app/views/profiling Expand file tree Collapse file tree 5 files changed +16
-29
lines changed Original file line number Diff line number Diff line change 11import { useMemo , useState } from 'react' ;
22import { Outlet } from 'react-router-dom' ;
3- import styled from '@emotion/styled' ;
43
5- import * as Layout from 'sentry/components/layouts/thirds' ;
64import { ContinuousProfileHeader } from 'sentry/components/profiling/continuousProfileHeader' ;
75import type { RequestState } from 'sentry/types/core' ;
86import type { EventTransaction } from 'sentry/types/event' ;
@@ -11,6 +9,7 @@ import {decodeScalar} from 'sentry/utils/queryString';
119import { useLocation } from 'sentry/utils/useLocation' ;
1210import { useOrganization } from 'sentry/utils/useOrganization' ;
1311import { useParams } from 'sentry/utils/useParams' ;
12+ import { LayoutPageWithHiddenFooter } from 'sentry/views/profiling/utils' ;
1413
1514import { ContinuousProfileProvider , ProfileTransactionContext } from './profilesProvider' ;
1615
@@ -79,9 +78,3 @@ export default function ProfileAndTransactionProvider(): React.ReactElement {
7978 </ ContinuousProfileProvider >
8079 ) ;
8180}
82-
83- const LayoutPageWithHiddenFooter = styled ( Layout . Page ) `
84- ~ footer {
85- display: none;
86- }
87- ` ;
Original file line number Diff line number Diff line change @@ -6,7 +6,6 @@ import {vec2} from 'gl-matrix';
66
77import { addErrorMessage } from 'sentry/actionCreators/indicator' ;
88import Feature from 'sentry/components/acl/feature' ;
9- import * as Layout from 'sentry/components/layouts/thirds' ;
109import { usePageFilters } from 'sentry/components/pageFilters/usePageFilters' ;
1110import { DifferentialFlamegraphLayout } from 'sentry/components/profiling/flamegraph/differentialFlamegraphLayout' ;
1211import { FlamegraphContextMenu } from 'sentry/components/profiling/flamegraph/flamegraphContextMenu' ;
@@ -42,6 +41,7 @@ import {FlamegraphRendererWebGL} from 'sentry/utils/profiling/renderers/flamegra
4241import { Rect } from 'sentry/utils/profiling/speedscope' ;
4342import { useLocation } from 'sentry/utils/useLocation' ;
4443import { LOADING_PROFILE_GROUP } from 'sentry/views/profiling/profileGroupProvider' ;
44+ import { LayoutPageWithHiddenFooter } from 'sentry/views/profiling/utils' ;
4545
4646const PROFILE_TYPE = 'differential aggregate flamegraph' as const ;
4747
@@ -351,12 +351,6 @@ const DifferentialFlamegraphContainer = styled('div')`
351351 flex: 1;
352352` ;
353353
354- const LayoutPageWithHiddenFooter = styled ( Layout . Page ) `
355- ~ footer {
356- display: none;
357- }
358- ` ;
359-
360354function DifferentialFlamegraphWithProviders ( ) {
361355 return (
362356 < LayoutPageWithHiddenFooter >
Original file line number Diff line number Diff line change @@ -69,6 +69,7 @@ import {
6969import { ProfilesSummaryChart } from 'sentry/views/profiling/landing/profilesSummaryChart' ;
7070import { ProfileGroupProvider } from 'sentry/views/profiling/profileGroupProvider' ;
7171import { ProfilesTable } from 'sentry/views/profiling/profileSummary/profilesTable' ;
72+ import { LayoutPageWithHiddenFooter } from 'sentry/views/profiling/utils' ;
7273
7374import { MostRegressedProfileFunctions } from './regressedProfileFunctions' ;
7475import { SlowestProfileFunctions } from './slowestProfileFunctions' ;
@@ -632,12 +633,6 @@ const ProfileVisualizationContainer = styled('div')<{hideRegressions}>`
632633 flex: 1 1 100%;
633634` ;
634635
635- const LayoutPageWithHiddenFooter = styled ( Layout . Page ) `
636- ~ footer {
637- display: none;
638- }
639- ` ;
640-
641636const ProfileSummaryContainer = styled ( 'div' ) `
642637 display: flex;
643638 flex-direction: column;
Original file line number Diff line number Diff line change 11import { useState } from 'react' ;
22import { Outlet } from 'react-router-dom' ;
3- import styled from '@emotion/styled' ;
43
5- import * as Layout from 'sentry/components/layouts/thirds' ;
64import { ProfileHeader } from 'sentry/components/profiling/profileHeader' ;
75import type { RequestState } from 'sentry/types/core' ;
86import type { EventTransaction } from 'sentry/types/event' ;
97import { isSchema , isSentrySampledProfile } from 'sentry/utils/profiling/guards/profile' ;
108import { useSentryEvent } from 'sentry/utils/profiling/hooks/useSentryEvent' ;
119import { useOrganization } from 'sentry/utils/useOrganization' ;
1210import { useParams } from 'sentry/utils/useParams' ;
11+ import { LayoutPageWithHiddenFooter } from 'sentry/views/profiling/utils' ;
1312
1413import { ProfileTransactionContext , TransactionProfileProvider } from './profilesProvider' ;
1514
@@ -62,9 +61,3 @@ export default function ProfileAndTransactionProvider(): React.ReactElement {
6261 </ TransactionProfileProvider >
6362 ) ;
6463}
65-
66- const LayoutPageWithHiddenFooter = styled ( Layout . Page ) `
67- ~ footer {
68- display: none;
69- }
70- ` ;
Original file line number Diff line number Diff line change 1+ import styled from '@emotion/styled' ;
2+
3+ import * as Layout from 'sentry/components/layouts/thirds' ;
14import {
25 isContinuousProfileReference ,
36 isTransactionProfileReference ,
47} from 'sentry/utils/profiling/guards/profile' ;
58
9+ // The footer component is a sibling of this div.
10+ // Remove it so the flamegraph can take up the
11+ // entire screen.
12+ export const LayoutPageWithHiddenFooter = styled ( Layout . Page ) `
13+ ~ footer {
14+ display: none;
15+ }
16+ ` ;
17+
618export function requestAnimationFrameTimeout ( cb : ( ) => void , timeout : number ) {
719 const rafId = { current : 0 } ;
820 const start = performance . now ( ) ;
You can’t perform that action at this time.
0 commit comments