ref(insights): Make SpanFields.SPAN_GROUP nullable

Move SPAN_GROUP from NonNullableStringFields to NullableStringFields,
reflecting the reality that OpenTelemetry-ingested spans can have null
span.group values. This makes SpanResponse['span.group'] resolve to
string | null, letting TypeScript catch unsafe usages.

Fix all surfaced type errors by updating prop types to accept null and
adding null coalescing where values are passed to MutableSearch.

Author: gggritso

static/app/components/events/eventStatisticalDetector/eventRegressionTable.tsx

@@ -18,7 +18,7 @@ import {formatPercentage} from 'sentry/utils/number/formatPercentage';
 import {unreachable} from 'sentry/utils/unreachable';
 
 export interface EventRegressionTableRow {
-  group: string;
+  group: string | null;
   operation: string;
   percentageChange: number;
   description?: string;

static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx

@@ -61,7 +61,7 @@ export function DetailsWidgetVisualization(props: DetailsWidgetVisualizationProp
         (spanDescription.split('?')[0] ?? '').split('.').pop()?.toLowerCase() ?? ''
       );
 
-    if (isImage) {
+    if (isImage && spanGroup) {
       const projectId = span[SpanFields.PROJECT_ID]
         ? Number(span[SpanFields.PROJECT_ID])
         : undefined;

static/app/views/insights/common/components/fullSpanDescription.tsx

@@ -21,7 +21,7 @@ const formatter = new SQLishFormatter();
 interface Props {
   moduleName: ModuleName;
   filters?: Record<string, string>;
-  group?: string;
+  group?: string | null;
   shortDescription?: string;
 }
 
@@ -33,7 +33,10 @@ export function FullSpanDescription({
 }: Props) {
   const {data: indexedSpans, isFetching: areIndexedSpansLoading} = useSpans(
     {
-      search: MutableSearch.fromQueryObject({'span.group': group, ...filters}),
+      search: MutableSearch.fromQueryObject({
+        'span.group': group ?? undefined,
+        ...filters,
+      }),
       limit: 1,
       fields: [
         SpanFields.PROJECT_ID,
@@ -104,7 +107,7 @@ export function FullSpanDescription({
 
 type TruncatedQueryClipBoxProps = {
   children: ReactNode;
-  group: string | undefined;
+  group: string | null | undefined;
 };
 
 function QueryClippedBox({group, children}: TruncatedQueryClipBoxProps) {

static/app/views/insights/common/components/spanDescription.tsx

@@ -49,7 +49,7 @@ export function DatabaseSpanDescription({
 
   const {data: indexedSpans, isFetching: areIndexedSpansLoading} = useSpans(
     {
-      search: MutableSearch.fromQueryObject({'span.group': groupId}),
+      search: MutableSearch.fromQueryObject({'span.group': groupId ?? undefined}),
       limit: 1,
       fields: [
         SpanFields.PROJECT_ID,

static/app/views/insights/common/components/spanGroupDetailsLink.tsx

@@ -17,7 +17,7 @@ interface Props {
   moduleName: ModuleName.DB | ModuleName.RESOURCE;
   projectId: number;
   extraLinkQueryParams?: Record<string, string>;
-  group?: string;
+  group?: string | null;
   spanOp?: string;
 }
 

static/app/views/insights/common/components/tableCells/spanDescriptionCell.tsx

@@ -19,7 +19,7 @@ interface Props {
   moduleName: ModuleName.DB | ModuleName.RESOURCE;
   projectId: number;
   extraLinkQueryParams?: Record<string, string>;
-  group?: string;
+  group?: string | null;
   spanAction?: string;
   spanOp?: string;
   system?: string;

static/app/views/insights/types.tsx

@@ -314,7 +314,6 @@ export type NonNullableStringFields =
   | SpanFields.FILE_EXTENSION
   | SpanFields.SPAN_OP
   | SpanFields.SPAN_DESCRIPTION
-  | SpanFields.SPAN_GROUP
   | SpanFields.SPAN_CATEGORY
   | SpanFields.SPAN_SYSTEM
   | SpanFields.TIMESTAMP
@@ -331,7 +330,7 @@ export type NonNullableStringFields =
   | SpanFields.USER_DISPLAY
   | SpanFields.SENTRY_ORIGIN;
 
-type NullableStringFields = SpanFields.NORMALIZED_DESCRIPTION;
+type NullableStringFields = SpanFields.NORMALIZED_DESCRIPTION | SpanFields.SPAN_GROUP;
 
 export type SpanStringFields = NullableStringFields | NonNullableStringFields;