Skip to content

Commit d81284e

Browse files
priscilawebdevClaude Opus 4.6
andcommitted
fix(layout): use LayoutPageWithHiddenFooter in profile summary
Move footer-hiding CSS from ProfileSummaryContainer to the Layout.Page wrapper. The ~ footer sibling selector broke when Layout.Page was added as a parent, since the footer is now a sibling of <main>, not the inner container. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
1 parent 4fe24a1 commit d81284e

File tree

1 file changed

+8
-11
lines changed
  • static/app/views/profiling/profileSummary

1 file changed

+8
-11
lines changed

static/app/views/profiling/profileSummary/index.tsx

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -632,19 +632,16 @@ const ProfileVisualizationContainer = styled('div')<{hideRegressions}>`
632632
flex: 1 1 100%;
633633
`;
634634

635+
const LayoutPageWithHiddenFooter = styled(Layout.Page)`
636+
~ footer {
637+
display: none;
638+
}
639+
`;
640+
635641
const ProfileSummaryContainer = styled('div')`
636642
display: flex;
637643
flex-direction: column;
638644
flex: 1 1 100%;
639-
640-
/*
641-
* The footer component is a sibling of this div.
642-
* Remove it so the flamegraph can take up the
643-
* entire screen.
644-
*/
645-
~ footer {
646-
display: none;
647-
}
648645
`;
649646

650647
const PROFILE_DIGEST_FIELDS = [
@@ -781,12 +778,12 @@ const ProfileDigestLabel = styled('span')`
781778

782779
export default function ProfileSummaryPageToggle() {
783780
return (
784-
<Layout.Page>
781+
<LayoutPageWithHiddenFooter>
785782
<ProfileSummaryContainer data-test-id="profile-summary-redesign">
786783
<ErrorBoundary>
787784
<ProfileSummaryPage />
788785
</ErrorBoundary>
789786
</ProfileSummaryContainer>
790-
</Layout.Page>
787+
</LayoutPageWithHiddenFooter>
791788
);
792789
}

0 commit comments

Comments
 (0)