fix(insights): End Sentry span in finally block, improve jest config comment

Move sentrySpan.end() to a finally block to prevent span leaks on
parse errors. Clarify moduleNameMapper comment explaining why the
manual paths are needed (ESM-only exports with no require condition).

Co-Authored-By: Claude <noreply@anthropic.com>

Author: gggritso

jest.config.ts

@@ -308,7 +308,8 @@ const config: Config.InitialOptions = {
     '^echarts/(.*)': '<rootDir>/tests/js/sentry-test/mocks/echartsMock.js',
     '^zrender/(.*)': '<rootDir>/tests/js/sentry-test/mocks/echartsMock.js',
 
-    // @sentry/sqlish uses ESM exports which Jest can't resolve directly
+    // @sentry/sqlish is ESM-only with `exports` that only define `import`
+    // conditions. Jest's CJS resolver can't follow them without explicit mapping.
     '^@sentry/sqlish/react$': '<rootDir>/node_modules/@sentry/sqlish/dist/react.js',
     '^@sentry/sqlish$': '<rootDir>/node_modules/@sentry/sqlish/dist/index.js',
 

static/app/utils/sqlish.tsx

@@ -42,7 +42,6 @@ export class SQLishFormatter {
 
     try {
       const result = fn();
-      sentrySpan?.end();
       return result;
     } catch (error: any) {
       Sentry.withScope(scope => {
@@ -63,6 +62,8 @@ export class SQLishFormatter {
 
       // If we fail to parse the SQL, return the original string
       return sql as unknown as T;
+    } finally {
+      sentrySpan?.end();
     }
   }
 }