ref(night-shift): Add bulk_read_preferences unified helper

Extract the feature-flag dispatch into a single bulk_read_preferences()
helper in autofix/utils.py that returns dict[int, SeerProjectPreference | None]
regardless of whether preferences come from Sentry DB or the Seer API.

Simplify _get_eligible_projects in the night-shift cron to use it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Agent transcript: https://claudescope.sentry.dev/share/rCNWD9ykr9zl5zpI-QmbkrWbXJLts9yV0ajkhGPjAsw

Author: chromy

src/sentry/seer/autofix/utils.py

@@ -818,6 +818,23 @@ def _get_project_option(key: str) -> Any:
     return result
 
 
+def bulk_read_preferences(
+    organization: Organization, project_ids: list[int]
+) -> dict[int, SeerProjectPreference | None]:
+    """Read Seer project preferences in bulk, using the correct source based on feature flag.
+
+    Always returns ``dict[int, SeerProjectPreference | None]`` regardless of the
+    underlying read path (Sentry DB or Seer API)."""
+    if features.has("organizations:seer-project-settings-read-from-sentry", organization):
+        return bulk_read_preferences_from_sentry_db(organization.id, project_ids)
+
+    raw = bulk_get_project_preferences(organization.id, project_ids)
+    return {
+        int(pid): SeerProjectPreference.validate(data) if data is not None else None
+        for pid, data in raw.items()
+    }
+
+
 def set_project_seer_preference(preference: SeerProjectPreference) -> None:
     """Set Seer project preference for a single project via Seer API."""
     response = make_set_project_preference_request(

src/sentry/tasks/seer/night_shift/cron.py

@@ -11,10 +11,7 @@
 from sentry.models.organization import Organization, OrganizationStatus
 from sentry.models.project import Project
 from sentry.seer.autofix.constants import AutofixAutomationTuningSettings
-from sentry.seer.autofix.utils import (
-    bulk_get_project_preferences,
-    bulk_read_preferences_from_sentry_db,
-)
+from sentry.seer.autofix.utils import bulk_read_preferences
 from sentry.seer.models.night_shift import SeerNightShiftRun, SeerNightShiftRunIssue
 from sentry.tasks.base import instrumented_task
 from sentry.tasks.seer.night_shift.agentic_triage import agentic_triage_strategy
@@ -182,20 +179,13 @@ def _get_eligible_projects(organization: Organization) -> list[Project]:
 
     project_ids = [p.id for p in projects]
     project_map = {p.id: p for p in projects}
-
-    if features.has("organizations:seer-project-settings-read-from-sentry", organization):
-        preferences = bulk_read_preferences_from_sentry_db(organization.id, project_ids)
-        projects_with_prefs = {pid for pid, pref in preferences.items() if pref is not None}
-    else:
-        preferences_by_id = bulk_get_project_preferences(organization.id, project_ids)
-        projects_with_prefs = {
-            int(pid) for pid, pref in preferences_by_id.items() if pref is not None
-        }
+    preferences = bulk_read_preferences(organization, project_ids)
 
     return [
         project_map[pid]
-        for pid in projects_with_prefs
-        if pid in project_map
+        for pid, pref in preferences.items()
+        if pref is not None
+        and pid in project_map
         and project_map[pid].get_option("sentry:autofix_automation_tuning")
         != AutofixAutomationTuningSettings.OFF
     ]