Skip to content

Commit ceb5a00

Browse files
ref(settings): Inline selectByValue in single-use tests
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7e065f4 commit ceb5a00

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

static/app/views/settings/account/apiNewToken.spec.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,7 @@ describe('ApiNewToken', () => {
161161
render(<ApiNewToken />);
162162
renderGlobalModal();
163163

164-
const selectByValue = (name: string, value: string) =>
165-
selectEvent.select(screen.getByRole('textbox', {name}), value);
166-
167-
await selectByValue('Project', 'Read');
164+
await selectEvent.select(screen.getByRole('textbox', {name: 'Project'}), 'Read');
168165

169166
await userEvent.click(screen.getByRole('button', {name: 'Create Token'}));
170167

@@ -217,10 +214,7 @@ describe('ApiNewToken', () => {
217214

218215
render(<ApiNewToken />);
219216

220-
const selectByValue = (name: string, value: string) =>
221-
selectEvent.select(screen.getByRole('textbox', {name}), value);
222-
223-
await selectByValue('Project', 'Read');
217+
await selectEvent.select(screen.getByRole('textbox', {name: 'Project'}), 'Read');
224218

225219
await userEvent.click(screen.getByRole('button', {name: 'Create Token'}));
226220

0 commit comments

Comments
 (0)