ref(cmdk): Extract getLocationHref and isExternalLocation to shared locationUtils

Both commandPalette.tsx and modal.tsx contained identical copies of these helpers. Move them to a shared locationUtils.ts module to eliminate duplication.

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

Author: JonasBa

static/app/components/commandPalette/ui/commandPalette.tsx

@@ -7,7 +7,6 @@ import {mergeProps} from '@react-aria/utils';
 import {Item} from '@react-stately/collections';
 import {useTreeState} from '@react-stately/tree';
 import {AnimatePresence, motion} from 'framer-motion';
-import type {LocationDescriptor} from 'history';
 
 import errorIllustration from 'sentry-images/spot/computer-missing.svg';
 
@@ -28,13 +27,13 @@ import {
   useCommandPaletteDispatch,
   useCommandPaletteState,
 } from 'sentry/components/commandPalette/ui/commandPaletteStateContext';
+import {isExternalLocation} from 'sentry/components/commandPalette/ui/locationUtils';
 import {useCommandPaletteAnalytics} from 'sentry/components/commandPalette/useCommandPaletteAnalytics';
 import {FeedbackButton} from 'sentry/components/feedbackButton/feedbackButton';
 import {LoadingIndicator} from 'sentry/components/loadingIndicator';
 import {IconArrow, IconClose, IconLink, IconOpen, IconSearch} from 'sentry/icons';
 import {IconDefaultsProvider} from 'sentry/icons/useIconDefaults';
 import {t} from 'sentry/locale';
-import {locationDescriptorToTo} from 'sentry/utils/reactRouter6Compat/location';
 import {fzf} from 'sentry/utils/search/fzf';
 import type {Theme} from 'sentry/utils/theme';
 import {useDebouncedValue} from 'sentry/utils/useDebouncedValue';
@@ -43,22 +42,6 @@ const MotionButton = motion.create(Button);
 const MotionIconSearch = motion.create(IconSearch);
 const MotionContainer = motion.create(Container);
 
-function getLocationHref(to: LocationDescriptor): string {
-  const resolved = locationDescriptorToTo(to);
-
-  if (typeof resolved === 'string') {
-    return resolved;
-  }
-
-  return `${resolved.pathname ?? ''}${resolved.search ?? ''}${resolved.hash ?? ''}`;
-}
-
-function isExternalLocation(to: LocationDescriptor): boolean {
-  const currentUrl = new URL(window.location.href);
-  const targetUrl = new URL(getLocationHref(to), currentUrl.href);
-  return targetUrl.origin !== currentUrl.origin;
-}
-
 function makeLeadingItemAnimation(theme: Theme) {
   return {
     initial: {scale: 0.95, opacity: 0},

static/app/components/commandPalette/ui/locationUtils.ts

@@ -0,0 +1,19 @@
+import type {LocationDescriptor} from 'history';
+
+import {locationDescriptorToTo} from 'sentry/utils/reactRouter6Compat/location';
+
+export function getLocationHref(to: LocationDescriptor): string {
+  const resolved = locationDescriptorToTo(to);
+
+  if (typeof resolved === 'string') {
+    return resolved;
+  }
+
+  return `${resolved.pathname ?? ''}${resolved.search ?? ''}${resolved.hash ?? ''}`;
+}
+
+export function isExternalLocation(to: LocationDescriptor): boolean {
+  const currentUrl = new URL(window.location.href);
+  const targetUrl = new URL(getLocationHref(to), currentUrl.href);
+  return targetUrl.origin !== currentUrl.origin;
+}

static/app/components/commandPalette/ui/modal.tsx

@@ -1,33 +1,19 @@
 import {useCallback} from 'react';
 import {css} from '@emotion/react';
-import type {LocationDescriptor} from 'history';
 
 import type {ModalRenderProps} from 'sentry/actionCreators/modal';
 import type {CMDKActionData} from 'sentry/components/commandPalette/ui/cmdk';
 import type {CollectionTreeNode} from 'sentry/components/commandPalette/ui/collection';
 import {CommandPalette} from 'sentry/components/commandPalette/ui/commandPalette';
 import {GlobalCommandPaletteActions} from 'sentry/components/commandPalette/ui/commandPaletteGlobalActions';
-import {locationDescriptorToTo} from 'sentry/utils/reactRouter6Compat/location';
+import {
+  getLocationHref,
+  isExternalLocation,
+} from 'sentry/components/commandPalette/ui/locationUtils';
 import type {Theme} from 'sentry/utils/theme';
 import {normalizeUrl} from 'sentry/utils/url/normalizeUrl';
 import {useNavigate} from 'sentry/utils/useNavigate';
 
-function getLocationHref(to: LocationDescriptor): string {
-  const resolved = locationDescriptorToTo(to);
-
-  if (typeof resolved === 'string') {
-    return resolved;
-  }
-
-  return `${resolved.pathname ?? ''}${resolved.search ?? ''}${resolved.hash ?? ''}`;
-}
-
-function isExternalLocation(to: LocationDescriptor): boolean {
-  const currentUrl = new URL(window.location.href);
-  const targetUrl = new URL(getLocationHref(to), currentUrl.href);
-  return targetUrl.origin !== currentUrl.origin;
-}
-
 export default function CommandPaletteModal({Body, closeModal}: ModalRenderProps) {
   const navigate = useNavigate();