Commit c1ae7a3
ref(cmdk): Remove onAction prop in favor of internal action execution (#112648)
Removes the onAction prop from commandPalette which was requiring us to
redefine the test and prod logic and diminishing the value of our tests.
With this change, the action.onAction or action.to are invoked
internally by the command palette.
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>1 parent cf3618d commit c1ae7a3
File tree
8 files changed
+116
-220
lines changed- static/app/components/commandPalette
- __stories__
- ui
8 files changed
+116
-220
lines changedLines changed: 5 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | 1 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
8 | 6 | | |
9 | | - | |
10 | | - | |
11 | 7 | | |
12 | 8 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | 9 | | |
30 | 10 | | |
31 | 11 | | |
| |||
49 | 29 | | |
50 | 30 | | |
51 | 31 | | |
52 | | - | |
| 32 | + | |
53 | 33 | | |
54 | 34 | | |
55 | 35 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | 53 | | |
61 | 54 | | |
62 | 55 | | |
| |||
0 commit comments