ref(gitlab): Address PR review feedback on status sync outbound

- URL-encode project_id in client.py to support path_with_namespace
  values (e.g. getsentry/sentry → getsentry%2Fsentry) when querying
  GitLab project issues API
- Rename mock_task → mock_schedule_webhooks in webhook update tests to
  accurately reflect that the RPC service method is being mocked, not
  a Celery task directly

Co-Authored-By: Claude <noreply@anthropic.com>

Author: iamrajjoshi

src/sentry/integrations/gitlab/client.py

@@ -467,7 +467,7 @@ def search_project_issues(self, project_id, query, iids=None):
 
         See https://docs.gitlab.com/ee/api/issues.html#list-project-issues
         """
-        path = GitLabApiClientPath.project_issues.format(project=project_id)
+        path = GitLabApiClientPath.project_issues.format(project=quote(str(project_id), safe=""))
 
         return self.get(path, params={"scope": "all", "search": query, "iids": iids})
 

tests/sentry/integrations/gitlab/test_integration.py

@@ -1187,13 +1187,13 @@ def test_update_organization_config_triggers_webhook_update_on_outdated_version(
 
         with patch(
             "sentry.integrations.gitlab.integration.repository_service.schedule_update_gitlab_project_webhooks"
-        ) as mock_task:
+        ) as mock_schedule_webhooks:
             # Update configuration
             data = {"sync_reverse_assignment": True}
             installation.update_organization_config(data)
 
             # Verify task was called with correct arguments
-            mock_task.assert_called_once_with(
+            mock_schedule_webhooks.assert_called_once_with(
                 organization_id=self.organization.id,
                 integration_id=integration.id,
             )
@@ -1233,13 +1233,13 @@ def test_update_organization_config_does_not_trigger_webhook_update_on_current_v
 
         with patch(
             "sentry.integrations.gitlab.integration.repository_service.schedule_update_gitlab_project_webhooks"
-        ) as mock_task:
+        ) as mock_schedule_webhooks:
             # Update configuration
             data = {"sync_reverse_assignment": True}
             installation.update_organization_config(data)
 
             # Verify task was NOT called
-            mock_task.assert_not_called()
+            mock_schedule_webhooks.assert_not_called()
 
         # Verify config was still updated
         org_integration = integration_service.get_organization_integration(
@@ -1277,13 +1277,13 @@ def test_update_organization_config_triggers_webhook_update_on_missing_version(
 
         with patch(
             "sentry.integrations.gitlab.integration.repository_service.schedule_update_gitlab_project_webhooks"
-        ) as mock_task:
+        ) as mock_schedule_webhooks:
             # Update configuration
             data = {"sync_comments": True}
             installation.update_organization_config(data)
 
             # Verify task was called
-            mock_task.assert_called_once_with(
+            mock_schedule_webhooks.assert_called_once_with(
                 organization_id=self.organization.id,
                 integration_id=integration.id,
             )
@@ -1322,13 +1322,13 @@ def test_update_organization_config_triggers_task_when_version_missing(self) ->
 
         with patch(
             "sentry.integrations.gitlab.integration.repository_service.schedule_update_gitlab_project_webhooks"
-        ) as mock_task:
+        ) as mock_schedule_webhooks:
             # Update configuration
             data = {"sync_reverse_assignment": False, "sync_comments": False}
             installation.update_organization_config(data)
 
             # Task should be called since version is missing (defaults to 0)
-            mock_task.assert_called_once_with(
+            mock_schedule_webhooks.assert_called_once_with(
                 organization_id=self.organization.id,
                 integration_id=integration.id,
             )