Skip to content

Commit b66bf27

Browse files
authored
fix(tracemetrics): Disable recent searches until ready (#113091)
Fixes a bug where clicking into the search bar too early was showing all these weird namespaced tracemetrics results.
1 parent 2aee310 commit b66bf27

File tree

1 file changed

+3
-3
lines changed
  • static/app/views/explore/metrics/metricToolbar

1 file changed

+3
-3
lines changed

static/app/views/explore/metrics/metricToolbar/filter.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,9 @@ export function Filter({traceMetric, skipTraceMetricFilter}: FilterProps) {
156156
searchSource: 'tracemetrics',
157157
namespace: traceMetric.name,
158158

159-
// Disable the recent searches when not using a trace metric filter because
160-
// the recent searches for metrics need to be namespaced on the trace metric filter.
161-
disableRecentSearches: skipTraceMetricFilter,
159+
// Disable the recent searches when not using a trace metric filter or when the metric name
160+
// is not set because the recent searches for metrics need to be namespaced on the trace metric filter.
161+
disableRecentSearches: skipTraceMetricFilter || !traceMetric.name,
162162
};
163163
}, [
164164
query,

0 commit comments

Comments
 (0)