Commit b4bb9a8
authored
fix(aci): Add support for an empty conditionGroup in the API for the Error detector (#112641)
# Description
Fixes:
https://linear.app/getsentry/issue/ISWF-2357/saving-error-monitor-after-creating-alert-fails
<img width="1080" height="394" alt="Screenshot 2026-04-09 at 4 18 21 PM"
src="https://github.com/user-attachments/assets/6e5d899e-5aef-486c-ac19-da6bebfb620d"
/>
The issue seems like that the validator for ErrorDetectors was throwing
because it has an empty data condition group; this should be okay and
makes sense in our UI to provide as a default.
Rather than updating the UI to not send the field, this PR will allow
the `{}` for the condition group.1 parent 2464008 commit b4bb9a8
File tree
3 files changed
+19
-3
lines changed- src/sentry/workflow_engine/endpoints/validators
- base
- tests/sentry/workflow_engine/detectors
3 files changed
+19
-3
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
| 225 | + | |
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
| |||
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
19 | 25 | | |
| 26 | + | |
20 | 27 | | |
21 | 28 | | |
22 | 29 | | |
| |||
31 | 38 | | |
32 | 39 | | |
33 | 40 | | |
34 | | - | |
| 41 | + | |
35 | 42 | | |
36 | 43 | | |
37 | 44 | | |
38 | | - | |
| 45 | + | |
| 46 | + | |
39 | 47 | | |
40 | 48 | | |
41 | 49 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
85 | 93 | | |
86 | 94 | | |
87 | 95 | | |
| |||
0 commit comments