feat(source-map-config-issues): Iterating

Author: Abdullah Khan

static/app/components/events/interfaces/crashContent/exception/content.tsx

@@ -165,7 +165,7 @@ function InnerContent({
   hasChainedExceptions: boolean;
   hiddenExceptions: ExceptionRenderStateMap;
   isSampleError: boolean;
-  sourceMapDebuggerData: SourceMapDebugBlueThunderResponse | undefined;
+  sourceMapDebuggerData: SourceMapDebugBlueThunderResponse;
   toggleRelatedExceptions: (exceptionId: number) => void;
   values: ExceptionValue[];
   project?: Project;
@@ -266,9 +266,11 @@ export function Content({
 }: Props) {
   const {projects} = useProjects({slugs: [projectSlug]});
 
-  const {data: sourceMapDebuggerData} = useSourceMapDebugQuery(projectSlug, event.id, {
-    sdkName: event.sdk?.name ?? null,
-  });
+  const {data: sourceMapDebuggerData} = useSourceMapDebugQuery(
+    projectSlug,
+    event.id,
+    event.sdk?.name ?? null
+  );
   const {hiddenExceptions, toggleRelatedExceptions, expandException} =
     useHiddenExceptions(values);
 

static/app/components/events/interfaces/crashContent/exception/useSourceMapDebuggerData.tsx

@@ -52,11 +52,11 @@ export interface SourceMapDebugBlueThunderResponse {
 export function useSourceMapDebugQuery(
   projectSlug: string,
   eventId: string,
-  options?: {sdkName?: string | null}
+  sdkName: string | null = null
 ) {
   const organization = useOrganization({allowNull: true});
-  const isSdkThatShouldShowSourceMapsDebugger = options?.sdkName
-    ? options.sdkName.startsWith('sentry.javascript.')
+  const isSdkThatShouldShowSourceMapsDebugger = sdkName
+    ? sdkName.startsWith('sentry.javascript.')
     : true;
   return useApiQuery<SourceMapDebugBlueThunderResponse>(
     [

static/app/components/stackTrace/issueStackTrace/issueSourceMapsDebuggerAction.tsx

@@ -27,9 +27,7 @@ export function IssueSourceMapsDebuggerAction() {
   const {data: sourceMapDebuggerData} = useSourceMapDebugQuery(
     project?.slug ?? '',
     event.id,
-    {
-      sdkName: event.sdk?.name ?? null,
-    }
+    event.sdk?.name ?? null
   );
   const debuggerFrame =
     exceptionIndex === undefined

static/app/views/issueDetails/configurationIssues/sourceMapIssues/diagnosisSection.tsx

@@ -156,7 +156,7 @@ export function DiagnosisSection({sourceMapQuery}: DiagnosisSectionProps) {
     if (isPending) {
       return <LoadingIndicator mini />;
     }
-    if (isError || !data) {
+    if (isError) {
       return (
         <LoadingError
           message={t('Unable to load source map diagnostic information for this event.')}

static/app/views/issueDetails/configurationIssues/sourceMapIssues/problemSection.tsx

@@ -21,6 +21,7 @@ export function ProblemSection() {
           size="sm"
           icon={<IconInfo />}
           external
+          // TODO Abdullah Khan: Look into adding platform specific links to source map docs
           href="https://docs.sentry.io/platforms/javascript/sourcemaps/"
         >
           {t('Why configure source maps?')}

static/app/views/issueDetails/configurationIssues/sourceMapIssues/sourceMapIssueDetails.tsx

@@ -17,7 +17,8 @@ interface SourceMapIssueDetailsProps {
 export function SourceMapIssueDetails({event, project}: SourceMapIssueDetailsProps) {
   const sourceMapQuery = useSourceMapDebugQuery(
     project.slug,
-    event.occurrence?.evidenceData?.sampleEventId
+    event.occurrence?.evidenceData?.sampleEventId,
+    event.sdk?.name ?? null
   );
 
   return (

static/app/views/issueDetails/streamline/context.tsx

@@ -103,10 +103,6 @@ export const enum SectionKey {
 
   PROFILE_PREVIEW = 'profile-preview',
   STACKTRACE_FLAMEGRAPH = 'stacktrace-flamegraph',
-
-  CONFIGURATION_PROBLEM = 'configuration-problem',
-  CONFIGURATION_DIAGNOSIS = 'configuration-diagnosis',
-  CONFIGURATION_TROUBLESHOOTING = 'configuration-troubleshooting',
 }
 
 /**