Skip to content

Commit b32d74d

Browse files
authored
fix(seer): Fix spacing on the Seer overview page (#112407)
Put the `<div>` in there to break the parent `<Stack gap="lg">` which is added extra padding. The items all have padding-bottom so we're good. Also, remove the refresh button (possibly only for now?) because it makes the Configure button not upper-case anymore.
1 parent 67790db commit b32d74d

File tree

2 files changed

+15
-20
lines changed

2 files changed

+15
-20
lines changed

static/app/views/settings/seer/overview/codeReviewOverviewSection.tsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {organizationRepositoriesInfiniteOptions} from 'sentry/components/events/
1515
import {useSeerSupportedProviderIds} from 'sentry/components/events/autofix/utils';
1616
import {useBulkUpdateRepositorySettings} from 'sentry/components/repositories/useBulkUpdateRepositorySettings';
1717
import {getRepositoryWithSettingsQueryKey} from 'sentry/components/repositories/useRepositoryWithSettings';
18-
import {IconRefresh, IconSettings} from 'sentry/icons';
18+
import {IconSettings} from 'sentry/icons';
1919
import {t, tct, tn} from 'sentry/locale';
2020
import {DEFAULT_CODE_REVIEW_TRIGGERS} from 'sentry/types/integrations';
2121
import type {Organization} from 'sentry/types/organization';
@@ -65,7 +65,6 @@ export function CodeReviewOverviewSection({
6565
isPending,
6666
organization,
6767
data,
68-
refetch,
6968
}: Props) {
7069
const queryClient = useQueryClient();
7170

@@ -174,16 +173,8 @@ export function CodeReviewOverviewSection({
174173
<FieldGroup
175174
title={
176175
<Flex justify="between" gap="md" flexGrow={1}>
177-
<Flex align="center" gap="md">
178-
<span>{t('Code Review')}</span>
179-
<Button
180-
size="zero"
181-
priority="link"
182-
icon={<IconRefresh size="xs" />}
183-
aria-label={t('Reload repositories')}
184-
onClick={() => refetch()}
185-
/>
186-
</Flex>
176+
<span>{t('Code Review')}</span>
177+
187178
<Text uppercase={false}>
188179
<Link to={`/settings/${organization.slug}/seer/repos/`}>
189180
<Flex align="center" gap="xs">

static/gsApp/views/seerAutomation/settings.tsx

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,13 @@ export function SeerAutomationSettings() {
9494
)}
9595
/>
9696
<SeerSettingsPageContent>
97-
<SCMOverviewSection
98-
{...scmOverviewData}
99-
canWrite={canWrite}
100-
organizationSlug={organization.slug}
101-
/>
102-
10397
{showSeerOverview ? (
104-
<Fragment>
98+
<div>
99+
<SCMOverviewSection
100+
{...scmOverviewData}
101+
canWrite={canWrite}
102+
organizationSlug={organization.slug}
103+
/>
105104
<AutofixOverviewSection
106105
{...autofixOverviewData}
107106
canWrite={canWrite}
@@ -112,9 +111,14 @@ export function SeerAutomationSettings() {
112111
canWrite={canWrite}
113112
organization={organization}
114113
/>
115-
</Fragment>
114+
</div>
116115
) : (
117116
<Fragment>
117+
<SCMOverviewSection
118+
{...scmOverviewData}
119+
canWrite={canWrite}
120+
organizationSlug={organization.slug}
121+
/>
118122
<FieldGroup
119123
title={
120124
<Flex gap="md">

0 commit comments

Comments
 (0)