Skip to content

Commit b1d394c

Browse files
committed
remove category/subcategory
1 parent c2663fe commit b1d394c

File tree

4 files changed

+2
-17
lines changed

4 files changed

+2
-17
lines changed

src/sentry/seer/issue_detection.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ def create_issue_occurrence(
2525
organization_id: The organization ID
2626
project_id: The project ID where the issue should be created
2727
detected_issue: Dict containing DetectedIssue fields (title, explanation,
28-
impact, evidence, offender_span_ids, trace_id, transaction_name, etc.)
28+
impact, evidence, offender_span_ids, trace_id, transaction_name,
29+
group_for_fingerprint, etc.)
2930
3031
Returns:
3132
Dict with "success": True on successful issue creation
@@ -42,8 +43,6 @@ def create_issue_occurrence(
4243
"title": issue.title,
4344
"trace_id": issue.trace_id,
4445
"project_id": effective_project_id,
45-
"category": issue.category,
46-
"subcategory": issue.subcategory,
4746
},
4847
)
4948

src/sentry/tasks/llm_issue_detection/detection.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ class DetectedIssue(BaseModel):
8484
missing_telemetry: str | None = Field(None, max_length=MAX_LLM_FIELD_LENGTH)
8585
offender_span_ids: list[str]
8686
transaction_name: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH)
87-
category: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH)
88-
subcategory: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH)
8987
verification_reason: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH)
9088
group_for_fingerprint: str = Field(..., max_length=MAX_LLM_FIELD_LENGTH)
9189
project_id: int | None = None

tests/sentry/seer/test_issue_detection.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ def test_create_issue_occurrence_success(self, mock_create: Any) -> None:
2424
"missing_telemetry": None,
2525
"offender_span_ids": ["span1", "span2"],
2626
"title": "Test Issue",
27-
"subcategory": "test",
28-
"category": "performance",
2927
"verification_reason": "test reason",
3028
"trace_id": "abc123",
3129
"transaction_name": "/api/test",
@@ -62,8 +60,6 @@ def test_create_issue_occurrence_project_not_in_organization(self) -> None:
6260
"missing_telemetry": None,
6361
"offender_span_ids": ["span1", "span2"],
6462
"title": "Test Issue",
65-
"subcategory": "test",
66-
"category": "performance",
6763
"verification_reason": "test reason",
6864
"trace_id": "abc123",
6965
"transaction_name": "/api/test",
@@ -88,8 +84,6 @@ def test_create_issue_occurrence_uses_issue_project_id(self, mock_create: Any) -
8884
"missing_telemetry": None,
8985
"offender_span_ids": ["span1", "span2"],
9086
"title": "Test Issue",
91-
"subcategory": "test",
92-
"category": "performance",
9387
"verification_reason": "test reason",
9488
"trace_id": "abc123",
9589
"transaction_name": "/api/test",
@@ -120,8 +114,6 @@ def test_create_issue_occurrence_creation_fails(
120114
"missing_telemetry": None,
121115
"offender_span_ids": ["span1", "span2"],
122116
"title": "Test Issue",
123-
"subcategory": "test",
124-
"category": "performance",
125117
"verification_reason": "test reason",
126118
"trace_id": "abc123",
127119
"transaction_name": "/api/test",

tests/sentry/tasks/test_llm_issue_detection.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ def test_create_issue_occurrence_from_detection(self, mock_produce_occurrence):
8989
offender_span_ids=["span_1", "span_2"],
9090
trace_id="abc123xyz",
9191
transaction_name="test_transaction",
92-
subcategory="Connection Pool Exhaustion",
93-
category="Database",
9492
verification_reason="Problem is correctly identified",
9593
group_for_fingerprint="Slow Database Query",
9694
)
@@ -156,8 +154,6 @@ def test_create_issue_occurrence_uses_group_for_fingerprint_when_set(
156154
offender_span_ids=[],
157155
trace_id="trace456",
158156
transaction_name="GET /api",
159-
subcategory="N+1",
160-
category="Performance",
161157
verification_reason="Verified",
162158
group_for_fingerprint="N+1 Database Queries",
163159
)

0 commit comments

Comments
 (0)