ref(scm): Move protocol definitions to types.py (#111705)

Protocol definitions are expected to be imported by the end-user. They
should be in a public module. `types.py` makes the most sense.

Author: cmanallen

src/sentry/scm/actions.py

@@ -13,8 +13,20 @@
     map_repository_model_to_repository,
 )
 from sentry.scm.private.ipc import record_count_metric
-from sentry.scm.private.provider import (
+from sentry.scm.private.rate_limit import RateLimitProvider
+from sentry.scm.types import (
     ALL_PROTOCOLS,
+    SHA,
+    ActionResult,
+    ArchiveFormat,
+    ArchiveLink,
+    BranchName,
+    BuildConclusion,
+    BuildStatus,
+    CheckRun,
+    CheckRunOutput,
+    Comment,
+    Commit,
     CompareCommitsProtocol,
     CreateBranchProtocol,
     CreateCheckRunProtocol,
@@ -38,6 +50,7 @@
     DeletePullRequestCommentProtocol,
     DeletePullRequestCommentReactionProtocol,
     DeletePullRequestReactionProtocol,
+    FileContent,
     GetArchiveLinkProtocol,
     GetBranchProtocol,
     GetCheckRunProtocol,
@@ -58,34 +71,15 @@
     GetPullRequestReactionsProtocol,
     GetPullRequestsProtocol,
     GetTreeProtocol,
-    MinimizeCommentProtocol,
-    Provider,
-    RequestReviewProtocol,
-    UpdateBranchProtocol,
-    UpdateCheckRunProtocol,
-    UpdatePullRequestProtocol,
-)
-from sentry.scm.private.rate_limit import RateLimitProvider
-from sentry.scm.types import (
-    SHA,
-    ActionResult,
-    ArchiveFormat,
-    ArchiveLink,
-    BranchName,
-    BuildConclusion,
-    BuildStatus,
-    CheckRun,
-    CheckRunOutput,
-    Comment,
-    Commit,
-    FileContent,
     GitBlob,
     GitCommitObject,
     GitRef,
     GitTree,
     InputTreeEntry,
+    MinimizeCommentProtocol,
     PaginatedActionResult,
     PaginationParams,
+    Provider,
     PullRequest,
     PullRequestCommit,
     PullRequestFile,
@@ -96,12 +90,16 @@
     Repository,
     RepositoryId,
     RequestOptions,
+    RequestReviewProtocol,
     ResourceId,
     Review,
     ReviewComment,
     ReviewCommentInput,
     ReviewEvent,
     ReviewSide,
+    UpdateBranchProtocol,
+    UpdateCheckRunProtocol,
+    UpdatePullRequestProtocol,
 )
 
 

src/sentry/scm/private/facade.py

@@ -6,8 +6,7 @@
 
 from sentry.scm.private.helpers import exec_provider_fn
 from sentry.scm.private.ipc import record_count_metric
-from sentry.scm.private.provider import ALL_PROTOCOLS, Provider
-from sentry.scm.types import Referrer
+from sentry.scm.types import ALL_PROTOCOLS, Provider, Referrer
 
 
 def _delegating_method(name: str) -> Callable[..., Any]:

src/sentry/scm/private/helpers.py

@@ -8,11 +8,10 @@
 from sentry.models.repository import Repository as RepositoryModel
 from sentry.scm.errors import SCMCodedError, SCMError, SCMUnhandledException
 from sentry.scm.private.ipc import record_count_metric
-from sentry.scm.private.provider import Provider
 from sentry.scm.private.providers.github import GitHubProvider
 from sentry.scm.private.providers.gitlab import GitLabProvider
 from sentry.scm.private.rate_limit import RateLimitProvider, RedisRateLimitProvider
-from sentry.scm.types import ExternalId, ProviderName, Referrer, Repository, RepositoryId
+from sentry.scm.types import ExternalId, Provider, ProviderName, Referrer, Repository, RepositoryId
 
 
 def map_integration_to_provider(