Commit ade9321
fix(performance): Restore feature parity on EAP Sampled Events tab (#111891)
This chunky PR brings the Transaction Summary > Sampled Events tab up to
feature parity with the pre-EAP version (with a single exception).
What's fixed:
- You can sort columns
- Display of the HTTP method and Replay column is now conditional
- The Trace ID is now a link to the trace waterfall
- You can now Open In Explore (like the old Open In Discover)
- Filtering by percentile is back
What's different from the pre-EAP Sampled Events tab:
- The span category filter is no longer on the page. I don't know what
the behaviour is supposed to be because it was broken and inconsistent
on the pre-EAP version. If we ever spec it out we can bring it back.
After working through each item with Claude, the individual commits
looked okay but everything taken together was pretty terrible - I went
back and refactored it all back into (IMO) decent shape.
This PR got big, and is now borderline for reviewable size - I can
definitely split it up if it's difficult to review in its current form.
Fixes DAIN-1401.
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent e38736c commit ade9321
File tree
11 files changed
+1173
-332
lines changed- static/app/views
- insights
- performance
- eap
- transactionSummary/transactionEvents
11 files changed
+1173
-332
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
132 | 139 | | |
133 | 140 | | |
134 | 141 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
0 commit comments