Skip to content

Commit ade9321

Browse files
mjqclaude
andauthored
fix(performance): Restore feature parity on EAP Sampled Events tab (#111891)
This chunky PR brings the Transaction Summary > Sampled Events tab up to feature parity with the pre-EAP version (with a single exception). What's fixed: - You can sort columns - Display of the HTTP method and Replay column is now conditional - The Trace ID is now a link to the trace waterfall - You can now Open In Explore (like the old Open In Discover) - Filtering by percentile is back What's different from the pre-EAP Sampled Events tab: - The span category filter is no longer on the page. I don't know what the behaviour is supposed to be because it was broken and inconsistent on the pre-EAP version. If we ever spec it out we can bring it back. After working through each item with Claude, the individual commits looked okay but everything taken together was pretty terrible - I went back and refactored it all back into (IMO) decent shape. This PR got big, and is now borderline for reviewable size - I can definitely split it up if it's difficult to review in its current form. Fixes DAIN-1401. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent e38736c commit ade9321

File tree

11 files changed

+1173
-332
lines changed

11 files changed

+1173
-332
lines changed

static/app/views/insights/types.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,13 @@ export enum SpanFields {
129129
AI_TOTAL_COST = 'ai.total_cost',
130130
AI_TOTAL_TOKENS_USED = 'ai.total_tokens.used',
131131

132+
// Span Operation Breakdown fields
133+
SPANS_BROWSER = 'spans.browser',
134+
SPANS_DB = 'spans.db',
135+
SPANS_HTTP = 'spans.http',
136+
SPANS_RESOURCE = 'spans.resource',
137+
SPANS_UI = 'spans.ui',
138+
132139
// DB fields
133140
DB_SYSTEM = 'db.system', // TODO: this is a duplicate of `SPAN_SYSTEM`
134141

static/app/views/performance/eap/overviewSpansTable.tsx

Lines changed: 0 additions & 217 deletions
This file was deleted.

static/app/views/performance/eap/segmentSpansTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export function SegmentSpansTable({
6363
const {projects} = useProjects();
6464
const navigate = useNavigate();
6565

66-
const projectSlug = projects.find(p => p.id === `${eventView.project}`)?.slug;
66+
const projectSlug = projects.find(p => p.id === String(eventView.project[0]))?.slug;
6767
const spanCategory = decodeScalar(location.query?.[SpanFields.SPAN_CATEGORY]);
6868
const {selected, options} = getEAPSegmentSpansListSort(location, spanCategory);
6969

0 commit comments

Comments
 (0)