Skip to content

Commit aa02f39

Browse files
committed
simplify the code path since nothing is using the variables outside of the default values
1 parent 99c2578 commit aa02f39

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/sentry/workflow_engine/receivers/project_workflows.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import logging
22

33
from django.db import router, transaction
4-
from django.db.models import Model
54

65
from sentry.models.project import Project
76
from sentry.models.rule import Rule
@@ -36,19 +35,11 @@
3635
PLATFORMS_WITH_PRIORITY_ALERTS = ["python", "javascript"]
3736

3837

39-
# TODO - invert this so it's create_default_workflows
40-
def create_default_rules(
41-
project: Project,
42-
default_rules: bool = True,
43-
RuleModel: Model = Rule,
44-
):
45-
if not default_rules:
46-
return
47-
38+
def create_default_rules(project: Project) -> None:
4839
rule_data = DEFAULT_RULE_DATA
4940

50-
with transaction.atomic(router.db_for_write(RuleModel)):
51-
rule = RuleModel.objects.create(
41+
with transaction.atomic(router.db_for_write(Rule)):
42+
rule = Rule.objects.create(
5243
project=project,
5344
label=DEFAULT_RULE_LABEL,
5445
data=rule_data,

0 commit comments

Comments
 (0)