Skip to content

Commit a48dbb8

Browse files
romtsnclaude
andcommitted
fix(issue-details): Fix typescript errors in tombstones banner
Add explicit ExceptionValue type annotation for the mechanism check callback parameter, and add fallback for CodeBlock children to satisfy the string type constraint. Restore isError bail-out. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 36fa985 commit a48dbb8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

static/app/components/events/interfaces/crashContent/exception/androidNativeTombstonesBanner.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {usePrompt} from 'sentry/actionCreators/prompts';
88
import {DropdownMenu} from 'sentry/components/dropdownMenu';
99
import {IconClose} from 'sentry/icons';
1010
import {t} from 'sentry/locale';
11-
import type {EntryException, Event} from 'sentry/types/event';
11+
import type {EntryException, Event, ExceptionValue} from 'sentry/types/event';
1212
import {EntryType} from 'sentry/types/event';
1313
import {trackAnalytics} from 'sentry/utils/analytics';
1414
import {useOrganization} from 'sentry/utils/useOrganization';
@@ -40,7 +40,7 @@ function hasSignalHandlerMechanism(event: Event): boolean {
4040
}
4141
return (
4242
exceptionEntry.data.values?.some(
43-
value => value.mechanism?.type === 'signalhandler'
43+
(value: ExceptionValue) => value.mechanism?.type === 'signalhandler'
4444
) ?? false
4545
);
4646
}
@@ -92,7 +92,7 @@ export function AndroidNativeTombstonesBanner({event, projectId}: Props) {
9292
onTabClick={setCodeTab}
9393
language={codeTab === 'manifest' ? 'xml' : codeTab}
9494
>
95-
{CODE_SNIPPETS[codeTab]}
95+
{CODE_SNIPPETS[codeTab] ?? ''}
9696
</CodeBlock>
9797
<LinkButton
9898
style={{marginTop: '12px'}}

0 commit comments

Comments
 (0)