fix(autofix): Validate Seer-supported SCM providers for Seer project preferences (#112518)

Validate that only Seer-supported SCM providers (GitHub, GitHub
Enterprise) can be added to Seer project preferences.
- RepositorySerializer.validate_provider — rejects unsupported providers
at the API layer (covers ProjectSeerPreferencesEndpoint.post and
OrganizationAutofixAutomationSettingsEndpoint.post)
- get_autofix_repos_from_project_code_mappings — filters out unsupported
providers from code-mapping-derived repos (covers
_resolve_project_preference and configure_seer_for_existing_org)

This covers more of Seer's deletion task
`cleanup_stale_seer_preferences_task`, as part of the migration of Seer
settings from Seer to Sentry
([spec](https://www.notion.so/sentry/Tech-Spec-Migrate-Seer-Settings-to-Sentry-Database-3208b10e4b5d80f58ea0d7b77a301e2a)).

Author: srest2021

src/sentry/seer/autofix/utils.py

@@ -30,6 +30,7 @@
 from sentry.models.repository import Repository
 from sentry.net.http import connection_from_url
 from sentry.seer.autofix.constants import AutofixAutomationTuningSettings, AutofixStatus
+from sentry.seer.constants import SEER_SUPPORTED_SCM_PROVIDERS
 from sentry.seer.models import (
     BranchOverride,
     SeerApiError,
@@ -777,8 +778,13 @@ def get_autofix_repos_from_project_code_mappings(
         repo: Repository = code_mapping.repository
         repo_name_sections = repo.name.split("/")
 
-        # We expect a repository name to be in the format of "owner/name" for now.
-        if len(repo_name_sections) > 1 and repo.provider:
+        if (
+            # We expect a repository name to be in the format of "owner/name" for now.
+            len(repo_name_sections) > 1
+            # Filter out code mappings with unsupported providers.
+            and repo.provider
+            and repo.provider in SEER_SUPPORTED_SCM_PROVIDERS
+        ):
             repo_dict = {
                 "repository_id": repo.id,
                 "organization_id": repo.organization_id,

src/sentry/seer/endpoints/organization_autofix_automation_settings.py

@@ -31,6 +31,7 @@
     default_seer_project_preference,
     resolve_repository_ids,
 )
+from sentry.seer.constants import SEER_SUPPORTED_SCM_PROVIDERS
 from sentry.seer.models import SeerProjectPreference, SeerRepoDefinition
 from sentry.seer.utils import filter_repo_by_provider
 
@@ -67,6 +68,14 @@ class RepositorySerializer(CamelSnakeSerializer):
     base_commit_sha = serializers.CharField(required=False, allow_null=True)
     provider_raw = serializers.CharField(required=False, allow_null=True)
 
+    def validate_provider(self, value):
+        if value not in SEER_SUPPORTED_SCM_PROVIDERS:
+            supported = ", ".join(sorted(SEER_SUPPORTED_SCM_PROVIDERS))
+            raise serializers.ValidationError(
+                f'"{value}" is not a supported Seer provider. Supported providers: {supported}'
+            )
+        return value
+
     def validate_branch_overrides(self, value):
         if not value:
             return value

tests/sentry/autofix/test_utils.py

@@ -49,6 +49,30 @@ def test_get_repos_from_project_code_mappings_with_data(self) -> None:
         ]
         assert repos == expected_repos
 
+    def test_filters_out_unsupported_providers(self) -> None:
+        project = self.create_project()
+        github_repo = self.create_repo(
+            name="getsentry/sentry",
+            provider="integrations:github",
+            external_id="123",
+            integration_id=234,
+        )
+        self.create_code_mapping(project=project, repo=github_repo)
+
+        gitlab_repo = self.create_repo(
+            name="getsentry/sentry-gitlab",
+            provider="integrations:gitlab",
+            external_id="456",
+            integration_id=345,
+        )
+        self.create_code_mapping(
+            project=project, repo=gitlab_repo, stack_root="gitlab/", source_root="src/gitlab/"
+        )
+
+        repos = get_autofix_repos_from_project_code_mappings(project)
+        assert len(repos) == 1
+        assert repos[0]["provider"] == "integrations:github"
+
 
 class TestGetAutofixStateFromPrId(TestCase):
     @patch("sentry.seer.autofix.utils.make_signed_seer_api_request")

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py

@@ -1052,3 +1052,28 @@ def test_post_append_resolves_repo_id_for_existing_repos(
         assert len(seer_repos) == 2
         assert seer_repos[0].repository_id == existing_repo.id
         assert seer_repos[1].repository_id == new_repo.id
+
+    @patch(
+        "sentry.seer.endpoints.organization_autofix_automation_settings.bulk_set_project_preferences"
+    )
+    def test_post_rejects_unsupported_repo_provider(self, mock_bulk_set_preferences):
+        project = self.create_project(organization=self.organization)
+
+        repo_data = {
+            "provider": "gitlab",
+            "owner": "test-org",
+            "name": "test-repo",
+            "externalId": "12345",
+        }
+
+        response = self.client.post(
+            self.url,
+            {
+                "projectIds": [project.id],
+                "projectRepoMappings": {
+                    str(project.id): [repo_data],
+                },
+            },
+        )
+        assert response.status_code == 400
+        mock_bulk_set_preferences.assert_not_called()

tests/sentry/seer/endpoints/test_project_seer_preferences.py

@@ -684,6 +684,26 @@ def test_post_rejects_mismatched_repo_name_or_owner(self, mock_request: MagicMoc
         assert response.data["detail"] == "Invalid repository"
         mock_request.assert_not_called()
 
+    @patch("sentry.seer.endpoints.project_seer_preferences.make_set_project_preference_request")
+    def test_post_rejects_unsupported_repo_provider(self, mock_request: MagicMock) -> None:
+        request_data = {
+            "repositories": [
+                {
+                    "organization_id": self.org.id,
+                    "integration_id": "111",
+                    "provider": "gitlab",
+                    "owner": "getsentry",
+                    "name": "sentry",
+                    "external_id": "123456",
+                }
+            ],
+        }
+
+        response = self.client.post(self.url, data=request_data)
+
+        assert response.status_code == 400
+        mock_request.assert_not_called()
+
     @patch("sentry.seer.endpoints.project_seer_preferences.make_set_project_preference_request")
     def test_post_creates_seer_project_repository(self, mock_request: MagicMock) -> None:
         """Test that POST writes to SeerProjectRepository when feature flag is enabled."""