ref(seer): Refactor Code Review table to better optimistically update (#112979)

Actually update the query cache, and remove that weird workaround stuff

Author: ryan953

static/gsApp/views/seerAutomation/components/repoTable/seerRepoTable.tsx

@@ -107,18 +107,20 @@ export function SeerRepoTable() {
     isFetchingNextPage,
   } = result;
 
-  const [mutationData, setMutations] = useState<Record<string, RepositoryWithSettings>>(
-    {}
-  );
-
   const {mutate: mutateRepositorySettings} = useBulkUpdateRepositorySettings({
     onSuccess: mutations => {
-      setMutations(prev => {
-        const updated = {...prev};
-        mutations.forEach(mutation => {
-          updated[mutation.id] = mutation;
-        });
-        return updated;
+      const mutationMap = new Map(mutations.map(m => [m.id, m]));
+      queryClient.setQueryData(queryOptions.queryKey, prev => {
+        if (!prev) {
+          return prev;
+        }
+        return {
+          ...prev,
+          pages: prev.pages.map(page => ({
+            ...page,
+            json: page.json.map(repo => mutationMap.get(repo.id) ?? repo),
+          })),
+        };
       });
     },
     onSettled: mutations => {
@@ -192,10 +194,10 @@ export function SeerRepoTable() {
         <TablePanel>
           <SeerRepoTableHeader
             gridColumns={GRID_COLUMNS}
+            isFetchingNextPage={isFetchingNextPage}
+            isPending={isPending}
             mutateRepositorySettings={mutateRepositorySettings}
             onSortClick={setSort}
-            isPending={isPending}
-            isFetchingNextPage={isFetchingNextPage}
             sort={sort}
           />
           {isPending ? (
@@ -221,7 +223,6 @@ export function SeerRepoTable() {
               hasNextPage={hasNextPage}
               isFetchingNextPage={isFetchingNextPage}
               mutateRepositorySettings={mutateRepositorySettings}
-              mutationData={mutationData}
               repositories={repositories}
               scrollBodyRef={scrollBodyRef}
             />
@@ -236,14 +237,12 @@ function VirtualizedRepoTable({
   hasNextPage,
   isFetchingNextPage,
   mutateRepositorySettings,
-  mutationData,
   repositories,
   scrollBodyRef,
 }: {
   hasNextPage: boolean;
   isFetchingNextPage: boolean;
   mutateRepositorySettings: ReturnType<typeof useBulkUpdateRepositorySettings>['mutate'];
-  mutationData: Record<string, RepositoryWithSettings>;
   repositories: RepositoryWithSettings[];
   scrollBodyRef: React.RefObject<HTMLDivElement | null>;
 }) {
@@ -296,7 +295,6 @@ function VirtualizedRepoTable({
               gridColumns={GRID_COLUMNS}
               style={{transform: `translateY(${virtualItem.start}px)`}}
               mutateRepositorySettings={mutateRepositorySettings}
-              mutationData={mutationData}
               repository={repository}
             />
           );

static/gsApp/views/seerAutomation/components/repoTable/seerRepoTableRow.tsx

@@ -13,10 +13,7 @@ import {
 } from 'sentry/actionCreators/indicator';
 import {getRepoStatusLabel} from 'sentry/components/repositories/getRepoStatusLabel';
 import {useBulkUpdateRepositorySettings} from 'sentry/components/repositories/useBulkUpdateRepositorySettings';
-import {
-  getRepositoryWithSettingsQueryKey,
-  useRepositoryWithSettings,
-} from 'sentry/components/repositories/useRepositoryWithSettings';
+import {getRepositoryWithSettingsQueryKey} from 'sentry/components/repositories/useRepositoryWithSettings';
 import {SimpleTable} from 'sentry/components/tables/simpleTable';
 import {IconOpen} from 'sentry/icons/iconOpen';
 import {t} from 'sentry/locale';
@@ -35,36 +32,21 @@ import {useCanWriteSettings} from 'getsentry/views/seerAutomation/components/use
 interface Props {
   gridColumns: string;
   mutateRepositorySettings: ReturnType<typeof useBulkUpdateRepositorySettings>['mutate'];
-  mutationData: Record<string, RepositoryWithSettings>;
   repository: RepositoryWithSettings;
   style?: React.CSSProperties;
 }
 
 export function SeerRepoTableRow({
   gridColumns,
   mutateRepositorySettings,
-  mutationData,
-  repository: initialRepository,
+  repository,
   style,
 }: Props) {
   const queryClient = useQueryClient();
   const organization = useOrganization();
   const canWrite = useCanWriteSettings();
   const {isSelected, toggleSelected} = useListItemCheckboxContext();
 
-  // We're defaulting to read from the list data, which is passed in as `initialRepository`
-  // But if an update has been made to one record, we're going to enable reading
-  // from `useRepositoryWithSettings` which will have the latest data, letting us
-  // do optimistic updates, without re-rendering the entire table.
-  // `initialRepository` will become stale at that point, but we'll have fresh data
-  // in the cache to override it.
-  const {data, isError, isPending} = useRepositoryWithSettings({
-    repositoryId: initialRepository.id,
-    initialData: [initialRepository, undefined, undefined],
-    enabled: mutationData[initialRepository.id] !== undefined,
-  });
-  const repository = isError || isPending ? initialRepository : data;
-
   return (
     <Grid
       columns={gridColumns}