Skip to content

Commit 932e9c6

Browse files
nsdeschenesclaude
andcommitted
fix(explore): Fix initial query validation running more than once
Use a ref to guard the initial validation effect so it only fires once, and remove the eslint-disable comment by including the proper dependencies. Refs EXP-641 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 39c10a1 commit 932e9c6

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

static/app/views/explore/components/traceItemSearchQueryBuilder.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {useCallback, useEffect, useMemo} from 'react';
1+
import {useCallback, useEffect, useMemo, useRef} from 'react';
22

33
import type {SpanSearchQueryBuilderProps} from 'sentry/components/performance/spanSearchQueryBuilder';
44
import {
@@ -110,12 +110,13 @@ export function useTraceItemSearchQueryBuilderProps({
110110

111111
const {invalidFilterKeys, validateQuery} = useAttributeValidation(itemType, projects);
112112

113+
const initialQueryValidatedRef = useRef(false);
113114
useEffect(() => {
114-
if (initialQuery) {
115+
if (initialQuery && !initialQueryValidatedRef.current) {
115116
validateQuery(initialQuery);
117+
initialQueryValidatedRef.current = true;
116118
}
117-
// eslint-disable-next-line react-hooks/exhaustive-deps
118-
}, []);
119+
}, [initialQuery, validateQuery]);
119120

120121
const wrappedOnChange = useCallback(
121122
(query: string, state: CallbackSearchState) => {

0 commit comments

Comments
 (0)