fix(np): Updates issue renderer to properly extract tags, notes, event

Author: GabeVillalobos

src/sentry/notifications/platform/slack/renderers/issue.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from sentry import eventstore
 from sentry.models.group import Group
 from sentry.notifications.platform.renderer import NotificationRenderer
 from sentry.notifications.platform.slack.provider import SlackRenderable
@@ -9,6 +10,7 @@
     NotificationProviderKey,
     NotificationRenderedTemplate,
 )
+from sentry.services.eventstore.models import Event
 
 
 class IssueSlackRenderer(NotificationRenderer[SlackRenderable]):
@@ -23,17 +25,18 @@ def render[DataT: NotificationData](
 
         from sentry.integrations.slack.message_builder.issues import SlackIssuesMessageBuilder
 
-        group = Group.objects.get_from_cache(id=data.group_id)
-        event = None
+        group: Group = Group.objects.get_from_cache(id=data.group_id)
+        event: Event | None = None
         if data.event_id:
-            event = group.get_latest_event()
+            event = eventstore.backend.get_event_by_id(group.project.id, data.event_id)
 
         blocks_dict = SlackIssuesMessageBuilder(
             group=group,
             event=event,
-            tags=data.tags or None,
+            tags=data.rule.data.get("tags", "").split(",") or None,
             rules=[data.rule.to_rule()] if data.rule else None,
-            notes=data.notes or None,
+            notes=data.rule.data.get("notes", None) or None,
+            link_to_event=True,
         ).build(notification_uuid=data.notification_uuid)
 
         return SlackRenderable(

src/sentry/notifications/platform/templates/issue.py

@@ -2,7 +2,7 @@
 
 from typing import Any
 
-from pydantic import BaseModel, ConfigDict, Field
+from pydantic import BaseModel, ConfigDict
 
 from sentry.models.rule import Rule
 from sentry.notifications.platform.registry import template_registry
@@ -62,8 +62,6 @@ class IssueNotificationData(NotificationData):
     group_id: int
     event_id: str | None = None
     rule: SerializableRuleProxy | None = None
-    tags: set[str] = Field(default_factory=set)
-    notes: str = ""
     notification_uuid: str = ""
 
 
@@ -73,11 +71,16 @@ class IssueNotificationTemplate(NotificationTemplate[IssueNotificationData]):
     example_data = IssueNotificationData(
         group_id=1,
         event_id="abc123",
-        tags={"environment", "level"},
-        notes="example note",
         notification_uuid="test-uuid",
         rule=SerializableRuleProxy(
-            id=1, project_id=2, environment_id=3, label="Example Rule", data={}
+            id=1,
+            project_id=2,
+            label="Example Rule",
+            data={
+                "actions": [{"workflow_id": 3}],
+                "tags": "environment,level",
+                "notes": "example note",
+            },
         ),
     )
     hide_from_debugger = True